[template/angular-sxp] Fix build error of angular-sxp, service not fo…

…und (#1890) * remove jsslink service from bas app.module; inject it via providfedIn * update changelog
Sitecore · Aug 14, 2024 · f5e7731 · f5e7731
1 parent c525b47
commit f5e7731
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -31,7 +31,7 @@ Our versioning strategy is as follows:
   * `proxyAppDestination` arg can be passed into `create-sitecore-jss` command to define path for proxy to be installed in
 * `[create-sitecore-jss]``[template/angular-xmcloud]` Angular SXA components ([#1864](https://github.com/Sitecore/jss/pull/1864))
 * `[sitecore-jss-angular]` Angular placeholder now supports SXA components ([#1870](https://github.com/Sitecore/jss/pull/1870))
-* `[template/angular-xmcloud]` Angular SXA layout ([#1873](https://github.com/Sitecore/jss/pull/1873))([#1880](https://github.com/Sitecore/jss/pull/1880))
+* `[template/angular-xmcloud]` Angular SXA layout ([#1873](https://github.com/Sitecore/jss/pull/1873))([#1880](https://github.com/Sitecore/jss/pull/1880))([#1890](https://github.com/Sitecore/jss/pull/1890))
 
 ### 🛠 Breaking Change
 

diff --git a/packages/create-sitecore-jss/src/templates/angular-xmcloud/src/app/jss-link.service.ts b/packages/create-sitecore-jss/src/templates/angular-xmcloud/src/app/jss-link.service.ts
@@ -2,7 +2,9 @@ import { Inject, Injectable } from '@angular/core';
 import { DOCUMENT } from '@angular/common';
 import { HTMLLink } from '@sitecore-jss/sitecore-jss-angular';
 
-@Injectable()
+@Injectable({
+  providedIn: 'root',
+})
 export class JssLinkService {
   constructor(@Inject(DOCUMENT) private document: Document) {}
 

diff --git a/packages/create-sitecore-jss/src/templates/angular/src/app/app.module.ts b/packages/create-sitecore-jss/src/templates/angular/src/app/app.module.ts
@@ -11,7 +11,6 @@ import { JssTranslationClientLoaderService } from './i18n/jss-translation-client
 import { JssTranslationLoaderService } from './i18n/jss-translation-loader.service';
 import { GraphQLModule } from './jss-graphql.module';
 import { JssMetaService } from './jss-meta.service';
-import { JssLinkService } from './jss-link.service';
 
 @NgModule({
   imports: [
@@ -33,7 +32,6 @@ import { JssLinkService } from './jss-link.service';
     JssContextService,
     JssLayoutService,
     JssMetaService,
-    JssLinkService,
     // IMPORTANT: you must set the base href with this token, not a <base> tag in the HTML.
     // the Sitecore Experience Editor will not work correctly when a base tag is used.
     { provide: APP_BASE_HREF, useValue: '/' },