Replace for..in with for..of to save 6 bytes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the for..in-loop in the unpacking bootstrapper with a for..of loop. This shaves 6 bytes off of the total packed output. The for..of loop is supported by all current major browsers: Chrome since version 51, Firefox since version 13, Edge since version 12, Safari since version 7.1, Chrome for Android since version 38 and Safari Mobile since version 8.
|
Interesting new feature from ES6, thanks for sharing it. Now that most browsers support it, ES6 will most likely be allowed in js1k 2017 (for the record, it wasn't in 2016). I am a bit worried with the lack of support from IE 11 though. Same goes with arrow functions so I am considering adding "Use ES6 capabilities" as an option (checked by default). |
|
Putting ES6 usage behind an opt-out option flag sounds like a good idea. Should I add it to this pull request? |
|
No, thanks. I'll merge the PR first, then add the flag later as part as the refactor that is due for v5. |
Siorki
added a commit
that referenced
this pull request
Oct 14, 2016
Encapsulation of #53 in unpacking routine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the for..in-loop in the unpacking bootstrapper with a
for..of loop. This shaves 6 bytes off of the total packed output.
The for..of loop is supported by all current major browsers: Chrome
since version 51, Firefox since version 13, Edge since version 12,
Safari since version 7.1, Chrome for Android since version 38 and Safari
Mobile since version 8.