Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty mapping crashes thermal viewer #89

Closed
Siorki opened this issue Nov 5, 2018 · 1 comment
Closed

Empty mapping crashes thermal viewer #89

Siorki opened this issue Nov 5, 2018 · 1 comment
Assignees
@Siorki
Labels
bug
Milestone
5.0.3

Comments

@Siorki
Copy link
Owner

Siorki commented Nov 5, 2018

Issue only present in the debug page (not regPack.html)

If in a branch no preprocessing is performed (no hashing, no refactoring ..), the thermal mapping is empty.

Upon attempting to create the thermal view, RegPack crashes.

The ThermalViewer accesses the last element of the mapping without performing bounds checking.
@Siorki Siorki self-assigned this Nov 5, 2018
@Siorki Siorki added the bug label Nov 5, 2018
@Siorki Siorki added this to the 6.0 milestone Nov 5, 2018
Siorki added a commit that referenced this issue Nov 13, 2018
@Siorki
#89 : Range check for thermal mapping in viewer.
5748840 
Factorized DocumentMock, now used in both #42 and #89
@Siorki
Copy link
Owner Author

Siorki commented Nov 13, 2018

Added bounds checking, with a default identity mapping if none found.

5748840

@Siorki Siorki closed this as completed Nov 13, 2018
@Siorki Siorki modified the milestones: 6.0, 5.0.3 Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siorki Siorki

Labels
bug
Projects
None yet
Milestone
5.0.3
Development

No branches or pull requests
1 participant
@Siorki