Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should varsNotReassigned also includes 'g' for WebGL ? #39

Closed
gre opened this issue Feb 14, 2016 · 7 comments
Closed

should varsNotReassigned also includes 'g' for WebGL ? #39

gre opened this issue Feb 14, 2016 · 7 comments
Milestone

Comments

@gre
Copy link
Contributor

gre commented Feb 14, 2016

I can't use the CLI with WebGL, looks like the "g" gets overrided.

for(_='at$tion#Loca#:lo$9,e)8g.7=7�in�ra�er�1,�(r�ttrib��texA��return �);�1.0��vec�Shad�(�$tach�c,�uff��Ar�y�_SHADER,i=�func# �niformvar �void ma�(){gl_   Prog�m(�(7ARRAY_BUFFER,�;vary�g �2 uv;��cre$e��-��requestAnima#F�me(a�),7�a��t�shad�Source(a,i�compile�a����r�8{�a,t�VERTEX�r;�o=a;t�FRAGMENT�e,�n=a,c���7�o��n�l�k�c�use�c��u�getA�:(c,"p"��7enableV��(u�v�Po�t�(u,2,7FLOAT,!�0,0),[c]}�e�8{�r[e]||�[e]�getU:�[0]8)}�a�){��u1f(e(n,"b"),.5+.5*M$h.cos�/1e3)�d�w�s(7TRIANGLES,0,6)}�t="precision highp f9�u f9 b;    F�gColor=�4(uv.x,uv.y,b,�}",i="a�ute �2 p�  Posi#=�4(p,0.0,�uv=0.5*(p+�}",o�B�(�7b�dB��o�b�D$a�new F932�([-��-�����1]�STATIC_DRAW��n=r(i,t���';g=/[�-�7-:#$]/.exec(_);)with(_.split(g))_=join(shift());eval(_)
@gre
Copy link
Contributor Author

gre commented Feb 14, 2016

actually the bug is that g is in the regpack extractor and overrides the contextual g, I suggest to use 'G' instead. I'll provide it in a PR

@Siorki
Copy link
Owner

Siorki commented Feb 14, 2016

Rules for 2016 mention that both 2D and 3D contexts should be in c, but the shim keeps the definition for g.

d should also be included in varsNotReassigned as it now contains the document. So the initialization changes from abc to abcdg .

@Siorki Siorki added this to the 4.0.1 milestone Feb 14, 2016
Siorki added a commit that referenced this issue Feb 16, 2016
@Siorki
Copy link
Owner

Siorki commented Feb 16, 2016

PR #41 merged, thanks for the fix

@gre gre closed this as completed Feb 16, 2016
@Siorki
Copy link
Owner

Siorki commented Feb 16, 2016

Reopened - to include a default value of "abcdg" for varsNotReassigned

@Siorki Siorki reopened this Feb 16, 2016
Siorki added a commit that referenced this issue Feb 16, 2016
in addition to a, b and c.
@Siorki
Copy link
Owner

Siorki commented Feb 16, 2016

All set - PR merged and added d and g to varsNotReassigned

@Siorki Siorki closed this as completed Feb 16, 2016
@gre
Copy link
Contributor Author

gre commented Feb 16, 2016

cool :) thanks

@Siorki
Copy link
Owner

Siorki commented Feb 17, 2016

Reopening again - I didn't notice yesterday, but the first and second compression stages also need renaming g to G.

@Siorki Siorki reopened this Feb 17, 2016
Siorki added a commit that referenced this issue Feb 17, 2016
Renamed in code generated by crusher (1st stage) and straight char class
RegExp packer (2nd stage)
@Siorki Siorki closed this as completed Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants