This repository has been archived by the owner on Nov 17, 2018. It is now read-only.
Treat fanout (client) subscriptions as a no-op #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in issue #5, clients with subscriptions defined encounter
exceptions when they attempt to process check results as check requests.
With Sensu's forthcoming native silencing implementation, each client
definition will include a subscription for "client:$CLIENT_NAME". For the
purposes of this silencing implemetation, it's not important that the client
consume check requests from this subscription, but it is important that the
subscription is present in the client definition sent via keepalive messages.
When Sensu processes call
subscribe()
on the transport object, they pass aqueue type. Sensu server processes subscribe with type
:direct
whileSensu client processes use type
:fanout
. This distinction makes it possiblefor us to treat client subscriptions for this transport as a no-op.