Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Tooling Cherry Picks #1290

Merged
merged 15 commits into from
Nov 30, 2024
Merged

Conversation

Myzumi and others added 12 commits November 27, 2024 20:07
* First part of Remote Bwoinking

* This should technically work

* No Actoring

* Fixes Guid not sending over

* Making it work for the final.

* Fixes for api

* Moar Commants!

Just more Comments to mark Frontier changes.

* comment

* wops

* Fixes Naming Rules

* I Should also fix the naming in the actually code...

* Testing some new code

* Naming rule and dependency fix (hopefully)

* Serverside Webhook update on external sent ahelp messages

* Still get data from custom URL's, even if it dosent match a discord webhook

* Apply suggestions from code review (Part 1)

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>

* Apply suggestions from code review (Part 2)

* Bwoink system suggsetions

* missing BwoinkSystem changes

* Change access on BwoinkSystem._messageQueues

* Updates the Regex to support other Discord Clients (beta, alpha)

* Merge Fixes

* BwoinkSystem: explicitly match "canary."/"ptb."

---------

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Co-authored-by: Whatstone <whatston3@gmail.com>
* Make chat rate limits a general-purpose system.

Intending to use this with ahelps next.

* Rate limt ahelps

Fixes #28762

* Review comments
* Adding the admin prefix to the ahelp

* Updating the admin prefix

* The second update of the admin prefix

* Configuration correction
* Clear search criteria on loading aHelp window

* Pinning technology.

* Relay to aHelp window and discord if a user disconnect/reconnect

* Fix pinning localization

* Log disconnect, reconnects, bans to relay and admin in aHelp

* Drop to 5min to hold active conversations

* Update Content.Server/Administration/Systems/BwoinkSystem.cs

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* discord text styling if diconnect,reconnect,banned message.

* Pin icons instead of text

* Better Icons

* space

* Move button generation in to its own XAML

* List entry control

* Fix spaces

* Remove from active conversations on banned

* Discord if else block cleanup

* Better pin icons

* Move icons to stylesheet styleclass

* Better field order.

* PR review fixes

* fixes

---------

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
* Move PlayerRateLimitManager to shared

* Add interaction rate limits

* uncap tests
* A comprehensive rule list for joining admins and mid round command to get rule list added

* Fix up for when a rule is added vs started and some logging

* fix command help localization, fix admin flags and spam anouncement.

* Send admin message only to the joining player not all admins.

* Bit better formatting in chat box
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Nov 28, 2024
@sleepyyapril
Copy link
Contributor Author

Test fails unrelated

@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, Aidenkrz, FoxxoTrystan, Remuchi, DEATHB4DEFEAT, Peptide90 and Pspritechologist and removed request for a team November 28, 2024 19:45
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Nov 28, 2024
@FoxxoTrystan FoxxoTrystan added Size: 3-Medium For medium issues/PRs Holy Shit labels Nov 28, 2024
@FoxxoTrystan FoxxoTrystan added Priority: 3-Medium Needs to be resolved at some point Type: Port Brings something to here from another codebase labels Nov 28, 2024
@sleepyyapril
Copy link
Contributor Author

UPDATE: The bot side is ready, so long as you are using a RedBot instance. Cog is located here

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails are indeed unrelated.

@sleepyyapril
Copy link
Contributor Author

sleepyyapril commented Nov 29, 2024

Code review required for latest commit, made custom changes to allow for discord role being used as a title, discord color being used as color, and allowing you to change the admin bwoink name color.

@VMSolidus VMSolidus merged commit b8e75da into Simple-Station:master Nov 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Holy Shit Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants