Move from Pybind11 to nanobind #345
Commits on Aug 27, 2024
-
-
[bindings/python] update CMake listfile, targets and instruction-set.…
…cpp for nanobind [bindings/python] cmake : nanobind's helper function already sets prefix and suffix for us.
-
[bindings/python] instruction-set.cpp : fix crashes because of lack o…
…f std::string support + add relevant nanobind stl support header
-
[proxqp/sparse] explicitly delete copy ctor and operator, fixing conf…
…usion with is_copy_constructible-type traits
-
[bindings/python] expose-workspace.hpp : do pybind11 -> nanobind swap
+ only concerns def_* methods and pickling (now managed manually through setting the relevant special methods)
-
[bindings/python] expose-settings.hpp : do pybind11 -> nanobind swap
+ concerns def_* methods and pickling (now managed manually through setting the relevant special methods) + remove module_local(), as it is not supported in nanobind: https://nanobind.readthedocs.io/en/latest/porting.html#removed-features
-
[bindings/python] workspace, model : do pybind11 -> nanobind swap
+ concerns def_* methods and pickling (now managed manually through setting the relevant special methods) + remove module_local(), as it is not supported in nanobind: https://nanobind.readthedocs.io/en/latest/porting.html#removed-features + ::arg_v() no longer behaves the same. had to strip per-argument docstrings
-
[bindings/python] remove optional.hpp
+ nanobind has no out-of-the-box utility for tl::optional AFAIK + nanobind requires C++17 - hence proxsuite will be using std::optional anyway
-
[bindings/python] expose-solver.hpp : switch to nanobind
+ this nuked a bunch of argument docstrings...
-
[bindings/python] expose-{backward,parallel,qpobject}.hpp : switch to…
… nanobind + this nuked a bunch of argument docstrings...
-
[bindings/python] expose-qpvector.hpp : upgrade to nanobind
+ change pybind11::return_value_policy to nanobind::rv_policy when relevant + include the nanobind header here (helps for IDEs) + change ctor init types from i64 to u64 -> nanobind is STRICT when it comes to integer signedness conversions
-
-
[bindings/python] cmake : add stub generation (basic)
pyproject.toml: add dependency on typing-extensions (required for stubgen on python<3.11) Make stub generation optional
-
-
-
[bindings/python] remove macro PROXSUITE_PYTHON_EIGEN_READWRITE
+ nanobind handles things well already
-
-
+ pickle expects to be loading a str instead of bytes
-
[bindings/python] Fix overloaded dense.solve() signatures, switch nul…
…lopt for nanobind::none()
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Update bindings/python/helpers/instruction-set.cpp
Co-authored-by: Fabian Schramm <55981657+fabinsch@users.noreply.github.com>
-
Update bindings/python/src/expose-results.hpp
Co-authored-by: Fabian Schramm <55981657+fabinsch@users.noreply.github.com>
-
Update bindings/python/src/expose-helpers.hpp
Co-authored-by: Fabian Schramm <55981657+fabinsch@users.noreply.github.com>
-
[workflows] do not re-run linux, osx, win, arch CI and release CI whe…
…n updating CHANGELOG.md
