Fix infeasibility detection logic #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabinsch
force-pushed
the
fix-infeas-detection
branch
from
d44e27e
to
13d44fa
Compare
jcarpent
previously approved these changes
Jun 11, 2024
fabinsch
force-pushed
the
fix-infeas-detection
branch
4 times, most recently
from
2390f84
to
25cb5b3
Compare
jcarpent
force-pushed
the
fix-infeas-detection
branch
from
25cb5b3
to
45e59d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a first check in our helper function
global_primal_residual_infeasibilitythat returns if a problem is supposed to be feasible.I think the logic we want to check is
in this case, the problem is feasible.
However, we negate this statement as the output of the function is used to set the variable called
is_primal_infeasible, here.If we negate the statement above, and should be replaced by OR. The fix I propose here solves the issue in #327 and proxqp returns
PROXQP_PRIMAL_INFEASIBLEas expected.