Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::declval instead of custom declval to avoid pack expansi… #290

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Jan 4, 2024

cl compiler doesn't succeed to do a parameter pack expansion whit our custom declval implementation.

To fix this issue, I have replaced the custom declval implementation by the standard one.

@jorisv jorisv self-assigned this Jan 4, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

@jorisv jorisv changed the title veg: Use std::declval instead of custom declval to avoid pack expansi… Use std::declval instead of custom declval to avoid pack expansi… Jan 4, 2024
@jorisv jorisv requested a review from ManifoldFR January 4, 2024 13:08
@jorisv jorisv marked this pull request as ready for review January 4, 2024 13:54
Copy link
Member

@ManifoldFR ManifoldFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me

@ManifoldFR ManifoldFR merged commit 958085f into Simple-Robotics:devel Jan 4, 2024
73 checks passed
@jorisv jorisv mentioned this pull request Jan 4, 2024
@jorisv jorisv deleted the topic/fix_windows_declval branch July 23, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants