-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dense LP interface #231
Merged
jcarpent
merged 4 commits into
Simple-Robotics:devel
from
Bambade:add_dense_LP_interface
Jun 19, 2023
Merged
Add dense LP interface #231
jcarpent
merged 4 commits into
Simple-Robotics:devel
from
Bambade:add_dense_LP_interface
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarpent
force-pushed
the
add_dense_LP_interface
branch
from
June 19, 2023 15:56
33fb13b
to
104f6e7
Compare
jcarpent
reviewed
Jun 19, 2023
jcarpent
reviewed
Jun 19, 2023
jcarpent
previously approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bambade Could you approved my suggested change?
Co-authored-by: Justin Carpentier <justin.carpentier@inria.fr>
Co-authored-by: Justin Carpentier <justin.carpentier@inria.fr>
jcarpent
approved these changes
Jun 19, 2023
This is great guys! Thanks! Do you have any benchmark on the performance gains? |
Solving #47. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting option for solving more efficiently Linear Programs with ProxQP, as suggested by #173 (i.e., all linear algebra operations involving the Hessian cost are avoided).
This PR adds this feature for ProxQP dense backend. It will be added later for ProxQP sparse backend as well.