Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with mingw #130

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Fix compilation with mingw #130

merged 1 commit into from
Nov 26, 2022

Conversation

jgillis
Copy link
Contributor

@jgillis jgillis commented Nov 25, 2022

@hrp2-14
Copy link
Member

hrp2-14 commented Nov 25, 2022

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jcarpent jcarpent changed the base branch from main to devel November 26, 2022 07:22
jcarpent
jcarpent approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jgillis for the fix

@jcarpent jcarpent merged commit fac0559 into Simple-Robotics:devel Nov 26, 2022
@jcarpent
Copy link
Member

@jgillis if needed, I've made a new release today: https://github.com/Simple-Robotics/proxsuite/releases/tag/v0.2.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgillis @hrp2-14 @CLAassistant @jcarpent