Release v1.0 #597
Merged
Release v1.0 #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add LoadingStatus Component Upgrade storybook to 6.1.17 Fix LoadingIndicator stories Add new Loading component Use Loading wrapper in Join page Separate Loading container from presentation Add Loading stories * Pass async action to LoadingStatus * Add PropTypes to LoadingStatus
Since an async action is called whithin a hook, it is guaranteed that it will be called within a component. It doesn't need to know anything about auth0.
* Add storybook esentials addon Use essential addons to develop components in isolation. See https://storybook.js.org/docs/react/essentials/introduction. * Add redux decorator to storybook All components will be wraped in store provider. Store state can be passed to container components thru components/story parameters. * Pass string instead of function to LoadingStatus Passing function just to avoid passing string, unnecessarily complicates the component and testing. * Add LoadingStatus stories * Fix bug in Loading component Loading component was returning children as a default option.
* started cleaning up imports * Cleaned up more imprts * Final import cleanup
* Add @storybook/addon-actions back to package.json The package is installed with @storybook/addon-essentials, so it doesn't affect package-lock.json. However, eslint warns that it should be listed as dependency. * Intercept dispatch in redux store decorator In order to develop components in isolation, all async calls should be intercepted and mocked. * Rename Join page file * Update relative paths * Remove history parameter from JoinPage History is no longer dependency of useEffects(), and it is passed to the HeaderSection, but never used. * Pass queueName from url params to HeaderSection Header section is visible while loading spinner. If queue exists, the name will be same as in url params. * Add JoinPage stories * Update QueueStats stories to storybook 6.x style * Reuse sotries data in JoinPage stories * Rename Join scss file * Rename Join form * Destrurcture props in JoinForm * Fix react wornings in JoinForm Callback chained to the promise was attempting to change the form after redirect, which was causing errors in the cosnole. * Add joining case to JoinPage stories This sotry desribes state after the user click Join button, before the request is fulfilled.
* added star button * added line break at bottom
* Rename home files * Rename Layout files * Refactor loading handling in Layout * Load user queues when isAuthenticated changes User queues were loaded on every round trip to the home page. This should be done only once when the user state is known, and on every change in user status or queue list (create/delete/pause). This also gives an opportunity to reuse MyQueues component in the Admin page. * Create alias for CreateJoinForm CreateJoinForm sounds like a function that will create JoinForm. QueueForm is a more appropriate name. It implies it's a queue Form, without explaining what form actions are. * Add MyQueues stories * Fix code style issues with Prettier Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
* Mock auth0 in storybook This allows components that depend on auth0 to be in developed in isolation. * Fix code style issues with Prettier Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
* Changed createJoinForm to use redux actions * Modified LoadingStatus and used in JoinPage and CreateJoinForm * Fixed a bug in fn call and a type
* Rename admin page file * Add getQueue() request creator * Add getSelectedQueue async action * Add selectedQueue slice * Add mock data for testing * Add Token stories * Remove token with dispatch * Add notifyToken() request creator * Add notifyToken() async action * Notify token with dispatch * Refactor NotifyButton * Extract CallButton * Redesign RemoveButton * Disable NotifyButton while notifyToken() is pending * Refactored delete queue (#551) * Refactored AddMember to use redux actions (#552) * Refactored AddMember * Fixed some imports * Added popup for adding to queues * Disable RemoveButton while dleteToken is pending * Refactor TaskList component * Extract AdminPage HeaderSection * Refactor AdminPage component * Fix: set timeoutId before clearing it Co-authored-by: Nithin <nithinjosetom@gmail.com>
* Add anonymous UUID to unauthinticated API Calls * Update jsdoc
…ts (#556) * Moved token selector to tokenlist * Moved getUserQueues dispatch to LandingPage to prevent unneeded popup on other page loads * Removed console.log * Moved getUserQueues back to Layout and changes the popup behaviour * Changed anchor tag redirects to use react router history * Add comments to layout * Fix code style issues with Prettier * Made utility function for delayed scrolling Co-authored-by: daltonfury42 <daltonfury42@users.noreply.github.com> Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
…mponents (#558) * Fixed queue details breaking for admin side panel * Made a QueueDetails component for admin * Changed loading condition * Removed LoadingIndicator * Removed useRequest and RequestFactory exports
* Replace makeAuthedRequest with hook Since no async actions use make authed request, remove it. * Rename Status page * Rename TokenStatusPage components * Add Token stories * Rename folder Status --> TokenStatus * Reuse TokenStatus stories
…n remove button + package updates (#589) * Updated packages and modified loading component * Removed showing error message * Reverting token remove button * Missed adding this file * Added pointer cursor style
|
I'm very glad to work with you all. I learnt many things here. I hope that we can take this project to next level. |
maaverik
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally happy to release v1.0. 🥇
This release brings in major improvements to the internal code structure, all thanks to @mradenovic. We learned a lot working with you. 🙏
Also included are a lot of improvements that were possible due to our migration to Redux.
Thanks to everyone who contributed code to this release:
@promarcussmith
@chalx
@prabureddy
@kabaliisa
@hallelshohat
@ME-ON1