Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Wrapper Validation #247

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Gradle Wrapper Validation #247

merged 3 commits into from
Dec 1, 2022

Conversation

oguzkocer
Copy link
Contributor

In Automattic/a8c-ci-toolkit-buildkite-plugin#34 we introduced our own script to validate the Gradle Wrapper which uses the official documentation for its implementation. This PR uses that script to add a prerequisite step to validate the Gradle Wrapper in Buildkite.

The main reason we decided to add our own script as opposed to using the official Github Action was to be able to validate the Gradle Wrapper before running any of the Buildkite steps. As discussed in that PR, there are some edge cases our script doesn't cover. Furthermore, because it's a custom implementation, there is always a chance that it gets outdated. Therefore, we are adding the official Github Action alongside our own script.

After this PR is merged, I suggest we add the Github Action as a required step for trunk branch. The Buildkite step is already a prerequisite for the rest of the steps, so I don't think we need to add it as a required check, but having the Github Action as a required check should give us some extra peace of mind. Github only takes ~20s to validate the wrapper, so it shouldn't block developers unless there is an issue with it.


Note that in order to use the bash-cache-buildkite-plugin, this PR also switches Buildkite builds from Docker to Android AMI. This is a change we have made in most of our repositories, but this is one of the repositories that was left behind.


To Test
Verify that the Gradle Wrapper Validation is added as a prerequisite step to the Buildkite pipeline.

@oguzkocer oguzkocer marked this pull request as ready for review December 1, 2022 12:36
@ParaskP7 ParaskP7 self-assigned this Dec 1, 2022
Copy link
Collaborator

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @oguzkocer !

Great work on the adding the Gradle Wrapper Validation checks in Simperium Android! 🥇 ❤️ 🚀

I've reviewed and tested the PR as per the description and everything LGTM:

  • Configuration Changes ✅
  • Buildkite ✅ PS: The build can be found here
  • GitHub Actions ✅

After this PR is merged, I suggest we add the Github Action as a required step for trunk branch.

I totally agree! 💯

@oguzkocer oguzkocer merged commit 8eecca0 into trunk Dec 1, 2022
@oguzkocer oguzkocer deleted the add/gradle-wrapper-validation branch December 1, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants