chore(eslint): enable strict rule set form @typescript-eslint

- fix linter errors
- remove no-type-assertion plugin

.eslintrc.js

@@ -6,7 +6,10 @@ module.exports = {
   },
   extends: [
     'eslint:recommended',
+    'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    'plugin:@typescript-eslint/strict',
     'plugin:import/recommended',
     'plugin:import/typescript',
     'plugin:jest/all',
@@ -15,24 +18,52 @@ module.exports = {
     // HINT: prettier must be the last extension to work
     'prettier',
   ],
+  ignorePatterns: ['coverage', 'lib', 'node_modules'],
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx'],
+      rules: {
+        'no-undef': 'off',
+        'no-unused-vars': 'off',
+      },
+    },
+  ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
     ecmaVersion: 2020,
-    sourceType: 'module',
+    project: ['./tsconfig.eslint.json'],
+    tsconfigRootDir: __dirname,
   },
   plugins: [
     '@typescript-eslint',
     'jest',
     'sonarjs',
     'sort-keys-fix',
     'typescript-sort-keys',
-    'no-type-assertion',
     // HINT: prettier must be the last plugin to work
     'prettier',
   ],
   rules: {
+    '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
+    '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
+    '@typescript-eslint/no-misused-promises': [
+      'error',
+      {
+        checksVoidReturn: false,
+      },
+    ],
+    '@typescript-eslint/no-unused-vars': [
+      'warn',
+      {
+        argsIgnorePattern: '^_',
+        caughtErrorsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+      },
+    ],
+    '@typescript-eslint/sort-type-union-intersection-members': 'error',
     camelcase: 'warn',
     curly: 'error',
+    'import/no-cycle': 'error',
     'import/no-unused-modules': [
       'error',
       {
@@ -52,7 +83,6 @@ module.exports = {
           caseInsensitive: true,
           order: 'asc',
         },
-        groups: ['builtin', 'external', 'internal'],
       },
     ],
     'import/prefer-default-export': 'off',
@@ -70,6 +100,15 @@ module.exports = {
     'prefer-const': 'error',
     'prettier/prettier': 'error',
     semi: 'error',
+    'sort-imports': [
+      'error',
+      {
+        ignoreCase: true,
+        ignoreDeclarationSort: true,
+        ignoreMemberSort: false,
+      },
+    ],
+    // Required to fix sort-keys automatically, since this is not done by default.
     'sort-keys-fix/sort-keys-fix': [
       'error',
       'asc',

src/commands/tag/tag.utils.test.ts

@@ -1,7 +1,7 @@
 import { composeTag } from './tag.utils';
 
 describe('composeTag', () => {
-  test('get Setup Uri for switch', async () => {
+  test('get Setup Uri for switch', () => {
     expect.assertions(1);
     const tag = composeTag('84131633');
 

src/index.ts

@@ -3,18 +3,22 @@
 
 import { createQrCode } from './commands/qrcode/qrcode';
 import { createTag } from './commands/tag/tag';
+import { isValidCategory } from './utils/isValidCategory';
 import { argv } from './yargs';
 
 const main = async () => {
   const { _: commands, name, output, pairingCode, zoom } = argv;
 
   if (commands[0] === 'qrcode') {
     const { category, flag, setupId = '' } = argv;
-    await createQrCode({ category, flag, name, output, pairingCode, setupId, zoom });
+    // Type-Guard since yargs does not support custom types that well
+    if (isValidCategory(category)) {
+      await createQrCode({ category, flag, name, output, pairingCode, setupId, zoom });
+    }
   }
   if (commands[0] === 'tag') {
     await createTag({ name, output, pairingCode, zoom });
   }
 };
 
-main();
+void main();

src/types/index.ts

@@ -3,6 +3,7 @@ import { OUTPUT_FORMATS } from '../config/output';
 
 export type Category = keyof typeof CATEGORIES;
 
+// eslint-disable-next-line prettier/prettier
 export type OutputFormat = typeof OUTPUT_FORMATS[number];
 
 export type CreateFileBuffer = CreateImage & {

src/utils/image.ts

@@ -1,7 +1,7 @@
 import { Resvg } from '@resvg/resvg-js';
 import { CreateImage } from '../types';
 
-export const createImage = async ({ svg, zoom = 5 }: CreateImage): Promise<Buffer> => {
+export const createImage = ({ svg, zoom = 5 }: CreateImage) => {
   const resvg = new Resvg(svg, {
     fitTo: {
       mode: 'zoom',

src/utils/isValidCategory.ts

@@ -0,0 +1,6 @@
+import { CATEGORIES } from '../config/categories';
+import { Category } from '../types';
+
+export const isValidCategory = (category: unknown): category is Category => {
+  return typeof category === 'string' && Object.keys(CATEGORIES).includes(category);
+};

tsconfig.eslint.json

@@ -0,0 +1,7 @@
+{
+  "compilerOptions": {
+    "rootDir": "."
+  },
+  "extends": "./tsconfig.json",
+  "include": [".", "./.eslintrc.js", "./jest.config.ts"]
+}