fix: stop only the current player and not all players #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprevost-LMI
force-pushed
the
stop-only-the-playing-player
branch
from
ec85926 to
3dabff7
Compare
|
FYI: This PR will unblock fixes required in this one |
|
@dprevost-LMI We have added new features to the example app; can you please rebase and update your implementation to take that into account? |
kuldip-simform
requested changes
Nov 14, 2024
fix: stop other player instead of the recoding when starting recording
dprevost-LMI
force-pushed
the
stop-only-the-playing-player
branch
from
caeb622 to
686e71f
Compare
|
Thank you for quick update. |
kuldip-simform
requested changes
Nov 15, 2024
kuldip-simform
requested changes
Nov 15, 2024
kuldip-simform
approved these changes
Nov 15, 2024
|
@mukesh-simform another PR to merge and unblock also #119, 🙇 |
mukesh-simform
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logic of starting or stopping a player or an audio recording triggers the stop action on all the players, which is useless, and when doing so with around 40 players, we see a noticeable lag when playing one audio after another.
By adding the
playerStateand theplayerKey,I could review the logic in the example app so that we could only stop the previous player from playing instead of all of them.Finally, by adding the
recorderState,I also managed to stop any player when starting a recording.Testing Proof of the changes
Screen.Recording.2024-11-09.at.10.46.08.AM.mov