fix: remove the hash calculation if hash exists #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 31, 2019 16:35
Remove the hash calculation and use the one already present in the `compilation` object (created in `HtmlWebpackPlugin`).
|
Thanks! This makes sense to me, I didn't know a hash was included. Could you add a test to fix test coverage? Just adding a |
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 56 58 +2
Branches 13 14 +1
=====================================
+ Hits 56 58 +2
Continue to review full report at Codecov.
|
|
Could we remove the hash options and just let this plugin inherit the setting from the |
|
@SimenB what do you think about my proposal? ^ |
SimenB
changed the title
SimenB
added a commit
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Ivan Vasilov <ivan@hfour.com>
This was referenced Nov 28, 2023
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the hash calculation and use the one already present in the
compilationobject (created inHtmlWebpackPlugin).The
hashoption doesn't make sense because this plugin is used withHtmlWebpackPluginand should inherit its option, not have a separate one. I can't think of a case where you would like different behavior (on hashes) for files included with this plugin.