Update bn.js to latest v4 version #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, this is an old module. I can certainly bump everything.
…Sent from my iPhone
On Nov 7, 2019, at 5:46 AM, Adrian Li ***@***.***> wrote:
This updates bn.js to its latest v4 version (i.e. 4.11.8).
Motivated by the fact that Web3.js (one of the largest users of this library) is also using this latest version. Note that I've kept the version pinned and also updated the build artifacts.
v5 of bn.js is already released, so it's unlikely that there will be much change for v4 going forward.
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
upgrade to latest v4 version of bn.js
update build artifacts
File Changes
M dist/number-to-bn.js (2186)
M dist/number-to-bn.js.map (2)
M dist/number-to-bn.min.js (5)
M package.json (3)
Patch Links:
https://github.com/SilentCicero/number-to-bn/pull/2.patch
https://github.com/SilentCicero/number-to-bn/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@SilentCicero thx mang |
|
@SilentCicero is there anything blocking a merge here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates bn.js to its latest v4 version (i.e.
4.11.8).Motivated by the fact that Web3.js (one of the largest users of this library) is also using this latest version. Note that I've kept the version pinned and also updated the build artifacts.
v5 of bn.js is already released, so it's unlikely that there will be much change for v4 going forward.