Added a local vector store memory backend option #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now rayon and simsimd are feature flags that are enabled by default. I have alternative methods for dot products and hamming distance for simsimd but I don't have an alternative search method that doesn't use Rayon. Is that something we should even add? Are we going to have users that don't want to use Rayon? |
I think "imposing" rayon is fine. You can always set a config flag that limits the max concurrency. Same goes for simd imo. |
McPatate
reviewed
Jul 9, 2024
SilasMarvin
force-pushed
the
silas-vector-store
branch
from
201ed9f to
bcb0cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.