-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add release CI #35
Conversation
29f0dec
to
e686d38
Compare
Wow this is really incredible thank you for adding all this! I am not very familiar with GitHub actions and have learned a lot reading through this. I'm not 100% sure why we changed Thank you for adding me as an author, I'm not 100% sure I want my email public though. Can we change it to |
112155d
to
3977898
Compare
There are most likely still some things we can do to cache builds but I don't think it's necessary on a release CI given it should be done seldomly! Glad you learned something 😄
There will be warnings on some platforms and it'll cause errors in the build. We could disable the visibility warnings but I think they can be useful at times, so I'd rather set the visibility to
Sorry about that, changed the commit and force pushed, it shouldn't be accessible anymore. |
Ported the CI from llm-ls