Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release CI #35

Merged
merged 18 commits into from
Jun 27, 2024
Merged

feat: add release CI #35

merged 18 commits into from
Jun 27, 2024

Conversation

McPatate
Copy link
Collaborator

Ported the CI from llm-ls

@McPatate McPatate requested a review from SilasMarvin June 26, 2024 08:49
@McPatate McPatate force-pushed the feat/add_release_ci branch 2 times, most recently from 29f0dec to e686d38 Compare June 26, 2024 12:51
@SilasMarvin
Copy link
Owner

Wow this is really incredible thank you for adding all this! I am not very familiar with GitHub actions and have learned a lot reading through this.

I'm not 100% sure why we changed pub to pub(crate) I thought that only ever meant anything for libraries?

Thank you for adding me as an author, I'm not 100% sure I want my email public though. Can we change it to silas.marvin@dmarvin.net that is an alias for me.

@McPatate McPatate force-pushed the feat/add_release_ci branch from 112155d to 3977898 Compare June 26, 2024 20:35
@McPatate
Copy link
Collaborator Author

Wow this is really incredible thank you for adding all this! I am not very familiar with GitHub actions and have learned a lot reading through this.

There are most likely still some things we can do to cache builds but I don't think it's necessary on a release CI given it should be done seldomly! Glad you learned something 😄
We could also add a CI to run the test suite on every push (caching would definitely be interesting here).

I'm not 100% sure why we changed pub to pub(crate) I thought that only ever meant anything for libraries?

There will be warnings on some platforms and it'll cause errors in the build. We could disable the visibility warnings but I think they can be useful at times, so I'd rather set the visibility to pub(crate).
Even though it is a binary, I believe visibility is determined at the module level regardless of what the target output is, lib or bin (don't quote me on that I need to check).

Thank you for adding me as an author, I'm not 100% sure I want my email public though. Can we change it to silas.marvin@dmarvin.net that is an alias for me.

Sorry about that, changed the commit and force pushed, it shouldn't be accessible anymore.

@SilasMarvin SilasMarvin merged commit 1f70756 into main Jun 27, 2024
@SilasMarvin SilasMarvin deleted the feat/add_release_ci branch June 27, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants