-
Notifications
You must be signed in to change notification settings - Fork 45k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(frontend): Auth pages update #9124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform/frontend
AutoGPT Platform - Front end
platform/backend
AutoGPT Platform - Back end
labels
Dec 23, 2024
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
kcze
commented
Dec 23, 2024
majdyz
previously approved these changes
Dec 27, 2024
majdyz
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are UX and design issues with current auth pages;
login
,signup
andreset_password
(including change password).Changes 🏗️
*Missing
s
on the login's password error is fixed.Important changes in bold.
All auth pages
/login
into/signup
StringPassword must be...")Sentry.withServerActionInstrumentation
PasswordInput
"eye button" shows password only when mouse button is hold and doesn't capture tabLogin page
actions.ts
Signup page
Reset password page
actions.ts
Other
types/auth
components/PasswordInput.tsx
to/components/auth
components/auth
yarn.lock
(supabase packages)client.ts
useSupabase
; user is simply not logged inChecklist 📋
For code changes:
/reset_password
Note: OAuth login providers are disabled and so untested.
Example test plan
For configuration changes:
.env.example
is updated or already compatible with my changesdocker-compose.yml
is updated or already compatible with my changesExamples of configuration changes