Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): Auth pages update #9124

Merged
merged 13 commits into from
Dec 30, 2024

Conversation

kcze
Copy link
Contributor

@kcze kcze commented Dec 23, 2024

There are UX and design issues with current auth pages; login, signup and reset_password (including change password).

Changes 🏗️

auth
*Missing s on the login's password error is fixed.

Important changes in bold.

All auth pages

  • Split /login into /signup
  • UI Redesign that adheres to Figma designs
  • General code cleanup and improvements
  • Fix feedback: it's now shown when needed and clear (e.g. "String Password must be...")
  • All action functions use Sentry.withServerActionInstrumentation
  • PasswordInput "eye button" shows password only when mouse button is hold and doesn't capture tab

Login page

  • Removed agree to terms checkbox (it's only on signup now)
  • Move provider login function to actions.ts

Signup page

  • Requires to type password twice
  • Shows waitlist information on any database error

Reset password page

  • Password update requires to type password twice
  • When request to send email is processed then the feedback is: Password reset email sent if user exists. Please check your email.
  • Email sent feedback is black, error is red
  • Move send email and update password functions to actions.ts
  • Disable button when email is sent

Other

  • Update zod schema objects and move them to types/auth
  • Move components/PasswordInput.tsx to /components/auth
  • Make common UI elements separate components in components/auth
  • Update yarn.lock (supabase packages)
  • Remove redundant letter in client.ts
  • Don't log error when user auth is missing in useSupabase; user is simply not logged in

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Form feedback:
      • Login works
      • Signup works
      • Reset email works
      • Change password works
    • Login works
    • Signup works
    • Reset email is sent
    • Reset email logs user in and redirects to /reset_password
    • Change password works
    • Logout works
    • All links across auth pages work

Note: OAuth login providers are disabled and so untested.

Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 59d4a8e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6772b7700d5b8a0008f165b4

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 59d4a8e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6772b77067d5db0008f77d8c

@kcze kcze marked this pull request as ready for review December 23, 2024 18:05
@kcze kcze requested a review from a team as a code owner December 23, 2024 18:05
@kcze kcze added this pull request to the merge queue Dec 30, 2024
Merged via the queue into dev with commit 15af2f4 Dec 30, 2024
20 checks passed
@kcze kcze deleted the kpczerwinski/secrt-988-login-page-feedback branch December 30, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/xl
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants