-
Notifications
You must be signed in to change notification settings - Fork 44.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Platform] Creator profile description no longer ignores new lines #9114
Merged
Torantulino
merged 4 commits into
Significant-Gravitas:dev
from
ethethanlee:marketplace/render-new-lines-in-description
Dec 21, 2024
Merged
[Platform] Creator profile description no longer ignores new lines #9114
Torantulino
merged 4 commits into
Significant-Gravitas:dev
from
ethethanlee:marketplace/render-new-lines-in-description
Dec 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethethanlee
requested review from
ntindle and
Swiftyos
and removed request for
a team
December 20, 2024 20:23
This PR targets the Automatically setting the base branch to |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
github-actions
bot
added
platform/frontend
AutoGPT Platform - Front end
platform/backend
AutoGPT Platform - Back end
and removed
Review effort [1-5]: 1
labels
Dec 20, 2024
✅ Deploy Preview for auto-gpt-docs canceled.
|
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
…/github.com/ethethanlee/AutoGPT into marketplace/render-new-lines-in-description
Torantulino
approved these changes
Dec 21, 2024
Thanks so much for your contribution @ethethanlee! |
Merged
via the queue into
Significant-Gravitas:dev
with commit Dec 21, 2024
10865cd
20 checks passed
Abhi1992002
pushed a commit
to Abhi1992002/AutoGPT
that referenced
this pull request
Dec 30, 2024
…ignificant-Gravitas#9114) Fixes Significant-Gravitas#9086 ### Changes 🏗️ Added styling to the div that encapsulates the description that takes white space into account ### Checklist 📋 #### Code changes: - [ x] I have clearly listed my changes in the PR description - [ x] I have made a test plan - [ x] I have tested my changes according to the test plan: <summary>The test plan was to just make changes to profile bio and check the creator page to see if new lines were generated properly</summary> Below is what the new change looks like: <img width="882" alt="Screenshot 2024-12-20 at 12 21 09 pm" src="https://github.com/user-attachments/assets/6d396ec7-96f8-4c9c-9d1f-a5bd75c6dc86" /> becomes... <img width="468" alt="Screenshot 2024-12-20 at 12 21 15 pm" src="https://github.com/user-attachments/assets/9dbe256b-5800-4f17-91c2-4ecffcffbc0b" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9086
Changes 🏗️
Added styling to the div that encapsulates the description that takes white space into account
Checklist 📋
Code changes:
Below is what the new change looks like:
becomes...