Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Creator profile description no longer ignores new lines #9114

Conversation

ethethanlee
Copy link
Contributor

Fixes #9086

Changes 🏗️

Added styling to the div that encapsulates the description that takes white space into account

Checklist 📋

Code changes:

  • [ x] I have clearly listed my changes in the PR description
  • [ x] I have made a test plan
  • [ x] I have tested my changes according to the test plan:
The test plan was to just make changes to profile bio and check the creator page to see if new lines were generated properly

Below is what the new change looks like:

Screenshot 2024-12-20 at 12 21 09 pm

becomes...

Screenshot 2024-12-20 at 12 21 15 pm

@ethethanlee ethethanlee requested a review from a team as a code owner December 20, 2024 20:23
@ethethanlee ethethanlee requested review from ntindle and Swiftyos and removed request for a team December 20, 2024 20:23
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

This PR targets the master branch but does not come from dev or a hotfix/* branch.

Automatically setting the base branch to dev.

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

9086 - Fully compliant

Compliant requirements:

  • Profile description text now renders new lines by adding white-space CSS property
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end and removed Review effort [1-5]: 1 labels Dec 20, 2024
@github-actions github-actions bot changed the base branch from master to dev December 20, 2024 20:23
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit f088d5f
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6765d50850b55e0008d36d0f

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit f088d5f
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6765d5081a71150008060c05

@Torantulino
Copy link
Member

Thanks so much for your contribution @ethethanlee!

@Torantulino Torantulino added this pull request to the merge queue Dec 21, 2024
Merged via the queue into Significant-Gravitas:dev with commit 10865cd Dec 21, 2024
20 checks passed
Abhi1992002 pushed a commit to Abhi1992002/AutoGPT that referenced this pull request Dec 30, 2024
…ignificant-Gravitas#9114)

Fixes Significant-Gravitas#9086

### Changes 🏗️

Added styling to the div that encapsulates the description that takes
white space into account

### Checklist 📋

#### Code changes:
- [ x] I have clearly listed my changes in the PR description
- [ x] I have made a test plan
- [ x] I have tested my changes according to the test plan:

<summary>The test plan was to just make changes to profile bio and check
the creator page to see if new lines were generated properly</summary>
  
  Below is what the new change looks like:
  
  
<img width="882" alt="Screenshot 2024-12-20 at 12 21 09 pm"
src="https://github.com/user-attachments/assets/6d396ec7-96f8-4c9c-9d1f-a5bd75c6dc86"
/>

becomes...

<img width="468" alt="Screenshot 2024-12-20 at 12 21 15 pm"
src="https://github.com/user-attachments/assets/9dbe256b-5800-4f17-91c2-4ecffcffbc0b"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/s
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Marketplace - Profile description text doesn't render new-lines
3 participants