Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): username not lowered when its updated #9112

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(store): username not lowered when its updated #9112

merged 1 commit into from
Dec 20, 2024

Conversation

Swiftyos
Copy link
Contributor

fix(store): username not lowered when its updated breaking access to any of there users pages in the store

@Swiftyos Swiftyos requested a review from a team as a code owner December 20, 2024 16:13
@Swiftyos Swiftyos requested review from aarushik93 and majdyz and removed request for a team December 20, 2024 16:13
@qodo-merge-pro Qodo Merge Pro
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Data Consistency

Verify that all other places where usernames are created/stored also use lowercase to maintain consistency across the application

                update_data["username"] = profile.username.lower()

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/s labels Dec 20, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 20, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit be94708
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/676597b1bc95a40008fb4d55

@netlify Netlify
Copy link

netlify bot commented Dec 20, 2024

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit be94708
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/676597b14f490a000833ae54

@Swiftyos Swiftyos enabled auto-merge December 20, 2024 16:40
@Swiftyos Swiftyos added this pull request to the merge queue Dec 20, 2024
Merged via the queue into dev with commit 1663d42 Dec 20, 2024
19 checks passed
@Swiftyos Swiftyos deleted the hotfix-lower-profile-name-on-save branch December 20, 2024 16:58
Abhi1992002 pushed a commit to Abhi1992002/AutoGPT that referenced this pull request Dec 30, 2024
@Swiftyos @Abhi1992002
fix(store): username not lowered when its updated (Significant-Gravit…
941c6b0 
…as#9112)

fix(store): username not lowered when its updated breaking access to any
of there users pages in the store
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle approved these changes

@aarushik93 aarushik93 Awaiting requested review from aarushik93 aarushik93 is a code owner automatically assigned from Significant-Gravitas/maintainers

@majdyz majdyz Awaiting requested review from majdyz majdyz is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end Review effort [1-5]: 1 size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swiftyos @ntindle