Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(platform):Refactor GraphExecution naming clash and remove unused Graph Execution functions #8939

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Dec 11, 2024

This is a follow-up of #8752

There are several APIs and functions related to graph execution that are unused now.
There is also confusion about the name of GraphExecution that exists in graph.py & execution.py.

Changes 🏗️

  • Renamed GraphExecution in execution.py to GraphExecutionEntry, this is only used as a queue entry for execution.
  • Removed unused get_graph_execution & list_executions in execution.py.
  • Removed with_run option on get_graph function in graph.py.
  • Removed GraphMetaWithRuns
  • Removed exposed functions only for testing.
  • Removed executions fields in Graph model.

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from kcze December 11, 2024 02:23
@majdyz majdyz requested a review from a team as a code owner December 11, 2024 02:23
@majdyz majdyz requested review from ntindle and removed request for a team December 11, 2024 02:23
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/l labels Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 8d9a5cc
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6759ab03ea027e00084f5015

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Class Renaming
Verify that renaming GraphExecution to GraphExecutionEntry doesn't break any external integrations or references not caught by the compiler

API Changes
Validate that removing the with_runs parameter from get_graphs() and removing list_graph_runs endpoint doesn't break any client functionality

Type Changes
Ensure removal of GraphMetaWithRuns type and its references is handled properly across the frontend codebase

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 8d9a5cc
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6759ab0302ff1c0008ca3820

kcze
kcze previously requested changes Dec 11, 2024
Copy link
Contributor

@kcze kcze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup 😊

majdyz and others added 3 commits December 11, 2024 22:07
Co-authored-by: Krzysztof Czerwinski <34861343+kcze@users.noreply.github.com>
Co-authored-by: Krzysztof Czerwinski <34861343+kcze@users.noreply.github.com>
@majdyz majdyz requested a review from kcze December 11, 2024 15:08
@majdyz majdyz added this pull request to the merge queue Dec 11, 2024
Merged via the queue into dev with commit 6490b4e Dec 11, 2024
21 checks passed
@majdyz majdyz deleted the zamilmajdy/refactor-graph-execution branch December 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 3 size/l
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants