Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for writing playwright tests #8877

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Dec 4, 2024

Nick wants others to be able to write tests besides Nick

Changes 🏗️

  • Fixes various import errors across the docs to fix dead links
  • Adds Docs for making and debugging your own tests

@ntindle ntindle requested a review from a team as a code owner December 4, 2024 01:53
@ntindle ntindle requested review from Swiftyos, kcze, Pwuts and Bentlybro and removed request for a team December 4, 2024 01:53
@github-actions github-actions bot added documentation Improvements or additions to documentation Forge platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit b30a739
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/675022cb0d458b0008e5a584

Copy link

qodo-merge-pro bot commented Dec 4, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Code Formatting
The file contains a comment warning about not running autoformatting. Consider finding a better solution that doesn't require disabling formatting, as this can lead to inconsistent code style.

Documentation Clarity
The test documentation could benefit from more examples of negative test cases and error handling scenarios, not just the happy path examples currently shown.

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit b30a739
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/675022cb220ff700085c235d

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@d4edb93). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #8877   +/-   ##
======================================
  Coverage       ?   58.16%           
======================================
  Files          ?      106           
  Lines          ?     5765           
  Branches       ?      720           
======================================
  Hits           ?     3353           
  Misses         ?     2306           
  Partials       ?      106           
Flag Coverage Δ
Linux 57.86% <ø> (?)
Windows 54.64% <ø> (?)
forge 58.03% <ø> (?)
macOS 57.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swiftyos
Copy link
Contributor

Swiftyos commented Dec 4, 2024

Very useful, thank you

@ntindle ntindle added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit 6b742d1 Dec 4, 2024
31 checks passed
@ntindle ntindle deleted the ntindle/open-1865-add-docs-on-playwright-testing-and-what-we-care-about branch December 4, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Forge platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/l
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants