Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Make Block description searchable on Block list palette #8839

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Nov 29, 2024

Blocks should be easy to search, the name is sometimes not straightforward, but the description does.

image

Changes πŸ—οΈ

Make the block description searchable.

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner November 29, 2024 02:41
@majdyz majdyz requested review from Torantulino and aarushik93 and removed request for a team November 29, 2024 02:41
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Code Duplication
The toLowerCase() call is repeated multiple times in the filter condition. Consider extracting searchQuery.toLowerCase() to a variable to avoid redundant calls

Copy link

netlify bot commented Nov 29, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 0e5d31f
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/674929c22ba7cb00080048ef

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/s labels Nov 29, 2024
Copy link

netlify bot commented Nov 29, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit 0e5d31f
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/674929c3cfc2e500086d69c7
😎 Deploy Preview https://deploy-preview-8839--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ntindle ntindle added this pull request to the merge queue Nov 29, 2024
Merged via the queue into dev with commit 520b1d7 Nov 29, 2024
19 checks passed
@ntindle ntindle deleted the zamilmajdy/search-block-on-description branch November 29, 2024 07:55
aarushik93 pushed a commit that referenced this pull request Dec 1, 2024
…te (#8839)

Blocks should be easy to search, the name is sometimes not
straightforward, but the description does.

<img width="576" alt="image"
src="https://github.com/user-attachments/assets/0528b019-0ebc-4e6f-8a3c-40323a671b13">


### Changes πŸ—οΈ

Make the block description searchable.

### Checklist πŸ“‹

#### For code changes:
- [ ] I have clearly listed my changes in the PR description
- [ ] I have made a test plan
- [ ] I have tested my changes according to the test plan:
  <!-- Put your test plan here: -->
  - [ ] ...

<details>
  <summary>Example test plan</summary>
  
  - [ ] Create from scratch and execute an agent with at least 3 blocks
- [ ] Import an agent from file upload, and confirm it executes
correctly
  - [ ] Upload agent to marketplace
- [ ] Import an agent from marketplace and confirm it executes correctly
  - [ ] Edit an agent from monitor, and confirm it executes correctly
</details>

#### For configuration changes:
- [ ] `.env.example` is updated or already compatible with my changes
- [ ] `docker-compose.yml` is updated or already compatible with my
changes
- [ ] I have included a list of my configuration changes in the PR
description (under **Changes**)

<details>
  <summary>Examples of configuration changes</summary>

  - Changing ports
  - Adding new services that need to communicate with each other
  - Secrets or environment variable changes
  - New or infrastructure changes such as databases
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 1 size/s
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants