Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Add the lower cap of the user credits to zero #8682

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Nov 18, 2024

Changes πŸ—οΈ

Add the lower cap of the user credits to zero.

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner November 18, 2024 04:19
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Logic Change
The change prevents negative credit values from being shown to users by using max(credit,0). Verify this doesn't hide important information about actual credit state from users or admins.

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/s and removed platform/backend AutoGPT Platform - Back end labels Nov 18, 2024
Copy link

netlify bot commented Nov 18, 2024

βœ… Deploy Preview for auto-gpt-docs ready!

Name Link
πŸ”¨ Latest commit 3ceefc4
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673b3c611d663f00088cf4ae
😎 Deploy Preview https://deploy-preview-8682--auto-gpt-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aarushik93 aarushik93 enabled auto-merge (squash) November 18, 2024 13:08
@github-actions github-actions bot added the platform/backend AutoGPT Platform - Back end label Nov 18, 2024
@aarushik93 aarushik93 merged commit 6fa4b8c into dev Nov 18, 2024
15 checks passed
@aarushik93 aarushik93 deleted the zamilmajdy/secrt-999-charge-block-credits-pre-execution-as-opposed-to-post branch November 18, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants