Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Remove double title on credentials input #8638

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 13, 2024

Changes 🏗️

  • Add back condition to hide credentials input title in CustomNode:generateInputHandles
  • Add title={schema.description} to <CredentialsInput> title element

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Create a block for which a system API key is present: should hide both the input and the title
    • Create a block for which no credentials are present: should show both the input and the title
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@Pwuts Pwuts requested a review from a team as a code owner November 13, 2024 14:20
@Pwuts Pwuts requested review from Torantulino and Bentlybro and removed request for a team November 13, 2024 14:20
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m labels Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit e2e3a76
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6734fd04da5fe2000839b56c
😎 Deploy Preview https://deploy-preview-8638--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pwuts Pwuts enabled auto-merge (squash) November 13, 2024 14:40
@Torantulino Torantulino self-assigned this Nov 13, 2024
@Pwuts Pwuts merged commit 5c0f979 into dev Nov 13, 2024
15 checks passed
@Pwuts Pwuts deleted the reinier/open-2035-fix-double-title-on-credentials-input branch November 13, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants