Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Broken UI caused by lack of error propagation on Run #8575

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Nov 6, 2024

Background

A few errors are being fixed here:

Changes 🏗️

Fixed the above issues (and display a short id on the node):
image

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

Configuration Changes 📝

Note

Only for the new autogpt platform, currently in autogpt_platform/

If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.

Examples of such changes might include:

  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested review from ntindle and aarushik93 November 6, 2024 13:37
@majdyz majdyz requested a review from a team as a code owner November 6, 2024 13:37
Copy link

qodo-merge-pro bot commented Nov 6, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Potential Performance Issue
The use of defaultdict for input_links might lead to unnecessary memory usage for large graphs. Consider using a regular dict with get() method instead.

Code Duplication
Similar logic for handling connections is repeated in NodeKeyValueInput and NodeArrayInput components. Consider extracting this logic into a separate function to improve maintainability.

Error Handling
The error handling in the catch block for saving an agent could be more specific. Consider handling different types of errors separately for better user feedback.

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m and removed platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Nov 6, 2024
@majdyz majdyz requested a review from Swiftyos November 6, 2024 13:57
@majdyz majdyz merged commit af9ea5b into dev Nov 7, 2024
10 checks passed
@majdyz majdyz deleted the zamilmajdy/fix-broken-ui branch November 7, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants