Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(platform): Tidy up repo structure #8521

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

Swiftyos
Copy link
Contributor

@Swiftyos Swiftyos commented Nov 1, 2024

Background

Tidying up repo a little

Changes 🏗️

  • Moved graph_templates up one level out of the backend project
  • Updated populate_db function to look in the new location
  • Removed example_files directory
  • Removed secrets directory

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

Configuration Changes 📝

Note

Only for the new autogpt platform, currently in autogpt_platform/

If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.

Examples of such changes might include:

  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@Swiftyos Swiftyos requested a review from a team as a code owner November 1, 2024 14:51
@Swiftyos Swiftyos requested review from ntindle and kcze and removed request for a team November 1, 2024 14:51
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/m labels Nov 1, 2024
Copy link

qodo-merge-pro bot commented Nov 1, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
The PR introduces multiple JSON templates that contain placeholders for API keys (Discord bot tokens and Medium API keys). While these are just placeholders, it's important to ensure that the actual implementation has proper safeguards to prevent accidental exposure of real API keys. Consider implementing a secure method for handling these sensitive credentials, such as using environment variables or a secure key management system.

⚡ Recommended focus areas for review

Sensitive Information Exposure
The template contains a placeholder for a Discord bot API key, which could lead to accidental exposure of sensitive information if not properly handled.

Sensitive Information Exposure
The template contains placeholders for Discord bot API keys, which could lead to accidental exposure of sensitive information if not properly handled.

Potential API Key Exposure
The template includes an empty API key field, which could potentially lead to accidental exposure of sensitive information if not properly secured.

@Swiftyos Swiftyos changed the title tidy up chore(platform): Tidy up repo structure Nov 1, 2024
@github-actions github-actions bot added the platform/frontend AutoGPT Platform - Front end label Nov 1, 2024
@Swiftyos Swiftyos merged commit 4d4cc60 into dev Nov 1, 2024
10 checks passed
@Swiftyos Swiftyos deleted the graph_template_tidy_up branch November 1, 2024 15:33
Pwuts added a commit that referenced this pull request Nov 18, 2024
…8692)

- Remove `secrets_dir` and other references to `get_secrets_path()`
- Remove unused `get_config_path()`

Follow-up to #8521, which removed the `secrets` dir but not the references to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 3 size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant