Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Enable auth on local-backend mode by default #8405

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Oct 23, 2024

Background

The app with ENABLE_AUTH=False without login is pretty much broken now.

Changes 🏗️

  • Makes the ENABLE_AUTH env variable default for local development to True:
  • Introduced docker compose --profile local up to bring up dependency services for ENABLE_AUTH, except the AutoGPT apps.
  • Fixed broken HTTP rerouting on failed auth.

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@majdyz majdyz requested review from ntindle and aarushik93 October 23, 2024 02:28
@majdyz majdyz requested a review from a team as a code owner October 23, 2024 02:28
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m labels Oct 23, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Configuration Change
The default value for frontend_base_url has been changed from an empty string to "http://localhost:3000". Ensure this change doesn't affect production environments or other deployment scenarios.

Authentication Flow
The condition for redirecting to the login page has been simplified. Verify that this change doesn't introduce any unintended behavior in the authentication flow.

Environment Configuration
ENABLE_AUTH is now set to true by default, and FRONTEND_BASE_URL is uncommented. Ensure these changes are communicated to the team and updated in deployment processes.

Documentation Update
The README has been updated with new instructions for running the server. Verify that these instructions are correct and complete.

Docker Configuration
A new service 'local_dependencies' has been added to the docker-compose file. Ensure this doesn't conflict with existing services and works as intended.

@majdyz majdyz requested a review from ntindle October 23, 2024 02:44
ntindle
ntindle previously approved these changes Oct 23, 2024
autogpt_platform/backend/test/__init__.py Show resolved Hide resolved
autogpt_platform/backend/.env.example Show resolved Hide resolved
autogpt_platform/backend/README.md Show resolved Hide resolved
@majdyz majdyz requested a review from ntindle October 23, 2024 03:28
@majdyz majdyz enabled auto-merge (squash) October 23, 2024 03:28
@majdyz majdyz merged commit 27c9ec5 into dev Oct 23, 2024
9 checks passed
@majdyz majdyz deleted the zamilmajdy/enable-auth-local branch October 23, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants