Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix classic ci #8338

Merged
merged 25 commits into from
Nov 15, 2024
Merged

ci: fix classic ci #8338

merged 25 commits into from
Nov 15, 2024

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Oct 14, 2024

Background

We moved from master -> dev for the mainline development branch without making sure it triggers the ci. This updates all the instances of development to dev for branch names. It does not attempt to verify the CI functions as needed under the new scheme

Changes 🏗️

  • find replace "development" -> "dev"
  • formating due to saving file in vscode
  • Don't error if folder exists in classic dockerfiles

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@ntindle ntindle requested a review from a team as a code owner October 14, 2024 19:11
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/xl labels Oct 14, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Branch Update
The branch names have been updated from 'development' to 'dev'. This change should be verified across all workflow files to ensure consistency.

Branch Update
The branch names have been updated from 'development' to 'dev'. This change should be verified across all workflow files to ensure consistency.

Branch Update
The branch name has been updated from 'development' to 'dev'. This change should be verified across all workflow files to ensure consistency.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@030ea6d). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #8338   +/-   ##
======================================
  Coverage       ?   49.62%           
======================================
  Files          ?      144           
  Lines          ?     8916           
  Branches       ?     1240           
======================================
  Hits           ?     4425           
  Misses         ?     4344           
  Partials       ?      147           
Flag Coverage Δ
Linux 49.43% <ø> (?)
Windows 50.03% <ø> (?)
agbenchmark 34.07% <ø> (?)
autogpt-agent 33.94% <ø> (?)
forge 58.03% <ø> (?)
macOS 48.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Oct 15, 2024
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Oct 15, 2024
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A million unrelated (formatting) changes, pls no

@Pwuts Pwuts changed the title ci(frontend,backend,classic): update branch from develop to dev ci: Change branch from develop to dev Oct 15, 2024
@ntindle
Copy link
Member Author

ntindle commented Oct 15, 2024

Don't worry i'll undo them all when I get the tests passing

@aarushik93
Copy link
Contributor

I didn't realise you had a PR for this already... but I merged one yesterday - does that fix what you are also trying to fix or completely different?

a2ef456

@Pwuts
Copy link
Member

Pwuts commented Oct 16, 2024

@aarushik93 this PR fixes a couple of references to develop that were missed in #8339

@ntindle
Copy link
Member Author

ntindle commented Oct 16, 2024

I didn't realise you had a PR for this already... but I merged one yesterday - does that fix what you are also trying to fix or completely different?

a2ef456

Imo your pr was great because it got the ones we use often working immediately

Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Oct 28, 2024
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Oct 29, 2024
@ntindle ntindle requested a review from Pwuts November 14, 2024 21:15
@github-actions github-actions bot added size/l and removed size/xl labels Nov 15, 2024
@ntindle
Copy link
Member Author

ntindle commented Nov 15, 2024

@aarushik93 ITS READY!

@ntindle ntindle changed the title ci: Change branch from develop to dev ci: fix classic ci Nov 15, 2024
@ntindle ntindle enabled auto-merge (squash) November 15, 2024 07:41
@ntindle ntindle merged commit ea214d9 into dev Nov 15, 2024
23 checks passed
@ntindle ntindle deleted the fix/ci branch November 15, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants