feat(rnd): Split Execution Manager #8008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d docker specific dns
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
added
conflicts
✅ Deploy Preview for auto-gpt-docs canceled.
|
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
conflicts
aarushik93
changed the title
aarushik93
commented
Sep 6, 2024
aarushik93
commented
Sep 6, 2024
aarushik93
commented
Sep 6, 2024
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
added
the
conflicts
aarushik93
force-pushed
the
aarushikansal/execution-manager
branch
from
98bf9bc to
2ce1717
Compare
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Swiftyos
previously approved these changes
Sep 9, 2024
Swiftyos
previously approved these changes
Sep 9, 2024
Pwuts
previously approved these changes
Sep 9, 2024
Swiftyos
previously approved these changes
Sep 9, 2024
majdyz
previously approved these changes
Sep 9, 2024
majdyz
approved these changes
Sep 9, 2024
ntindle
approved these changes
Sep 10, 2024
Comment on lines
+187
to
+192
| By default the daemons run on the following ports: | ||
|
|
||
| Execution Manager Daemon: 8002 | ||
| Execution Scheduler Daemon: 8003 | ||
| Rest Server Daemon: 8004 | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Running execution manager in a different pod to rest server, so we can scale independently as and when needed.
Changes 🏗️
To allow for this, updated to explicitly decide which ports to run the daemon's on (pyro choose its own dynamically).
To allow for service discovery, in three different environments:
locally, docker compose and k8s, we need a specific host (docker compose and k8s do their own service discovery and mapping based on service names), so introduced an environment variable to specify the host name (for local environments it's localhost, for k8s its the svc internal fully qualified domain name, for docker compose it's the service name).
Ports being used by the different services:
Execution Manager Daemon: 8002
Execution Scheduler Daemon: 8003
Rest Server Daemon: 8004
PR Quality Scorecard ✨
+2 pts+5 pts+5 pts+5 pts-4 pts+4 pts+5 pts-5 ptsagbenchmarkto verify that these changes do not regress performance?+10 pts