Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Builder): Add tooltips to Blocks and Save buttons #7975

Conversation

Bentlybro
Copy link
Member

@Bentlybro Bentlybro commented Sep 4, 2024

Background

This adds tooltips to the Blocks and Save buttons

This addresses: #7973

2024-09-04.18-04-53.mp4

Changes 🏗️

Imported the tooltip stuff to both the Blocks and Save button file and used that to add the tooltips

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@Bentlybro Bentlybro requested a review from a team as a code owner September 4, 2024 17:06
@Bentlybro Bentlybro requested review from Pwuts and kcze and removed request for a team September 4, 2024 17:06
@codiumai-pr-agent-pro codiumai-pr-agent-pro bot added the enhancement New feature or request label Sep 4, 2024
Copy link

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Description updated to latest commit (d79bc94)

@github-actions github-actions bot added the size/m label Sep 4, 2024
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit bae5f47
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66d99aaee72168000832a898

@github-actions github-actions bot added the platform/frontend AutoGPT Platform - Front end label Sep 4, 2024
Copy link

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Code Duplication
The Tooltip component structure is repeated in both files. Consider creating a reusable component for buttons with tooltips to reduce code duplication.

Accessibility
The tooltip delay duration is set to 500ms. Consider if this is sufficient time for users to perceive the tooltip, especially for users who might need more time to process information.

Copy link

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

No code suggestions found for the PR.

@Bentlybro Bentlybro enabled auto-merge (squash) September 4, 2024 17:18
@Bentlybro Bentlybro merged commit 1182783 into master Sep 5, 2024
12 checks passed
@Bentlybro Bentlybro deleted the bently/open-1791-block-and-save-buttons-dont-have-tooltip-hover branch September 5, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants