Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace - agent page - star rating is not visible in dark mode #9035

Closed
ograce1421 opened this issue Dec 17, 2024 · 3 comments
Closed

Marketplace - agent page - star rating is not visible in dark mode #9035

ograce1421 opened this issue Dec 17, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers platform/frontend AutoGPT Platform - Front end UI

Comments

@ograce1421
Copy link

ograce1421 commented Dec 17, 2024

Describe your issue.

Screenshot 2024-12-17 at 19 26 15 Screenshot 2024-12-17 at 19 27 03

Star icons are not visible when in dark mode. Please update so that the color is the same as the neighboring elements

@Swiftyos Swiftyos added platform/frontend AutoGPT Platform - Front end UI good first issue Good for newcomers labels Dec 18, 2024 — with Linear
@Abhi1992002 Abhi1992002 self-assigned this Dec 20, 2024
@Pawankalyan2023
Copy link

hey can i work on this issue ?

@Pawankalyan2023
Copy link

Can I get the file name where the issue arises and how to reproduce this ?

@Swiftyos
Copy link
Contributor

It's this code from autogpt_platform/frontend/src/components/ui/icons.tsx

/**
* Generates an array of JSX elements representing star icons based on the average rating.
*
* @param avgRating - The average rating (0 to 5)
* @returns An array of star icons as JSX elements
*/
export function StarRatingIcons(avgRating: number): JSX.Element[] {
 const stars: JSX.Element[] = [];
 const rating = Math.max(0, Math.min(5, avgRating));
 for (let i = 1; i <= 5; i++) {
   if (i <= rating) {
     stars.push(<IconStarFilled key={i} className="text-black" />);
   } else {
     stars.push(<IconStar key={i} className="text-black" />);
   }
 }
 return stars;
}

Though we just removed the dark mode toggle for todays release, so you'd need to add the dark mode toggle back in to be able to test these changes.

We will include dark mode again when all the pages look good in dark mode

Swiftyos added a commit that referenced this issue Dec 20, 2024
Add small ui changes on marketplace 

Fix
- #9035
- #9034 
- #9033
- #9031 
- #9029
- #9028
- #9027 
- #9026 
- #9025 
- #9021 
- #9020 
- #9004 
- #9003 
- #9002 
- #9001 
- #8999  
- #8998 
- #8997 
- #8996 
- #8995 
- #8994 
- #8993
- #8991   
- #8990 
- #8989

---------

Co-authored-by: Swifty <craigswift13@gmail.com>
@github-project-automation github-project-automation bot moved this to Done in Frontend Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers platform/frontend AutoGPT Platform - Front end UI
Projects
Status: Done
Development

No branches or pull requests

4 participants