Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify DX for adding providers and authenticated blocks #8931

Closed
Pwuts opened this issue Dec 10, 2024 — with Linear · 0 comments
Closed

Simplify DX for adding providers and authenticated blocks #8931

Pwuts opened this issue Dec 10, 2024 — with Linear · 0 comments
Assignees
@Pwuts
Labels
DX platform/backend AutoGPT Platform - Back end

Comments

@Pwuts Linear
Copy link
Member

Pwuts commented Dec 10, 2024

Outline

  1. For convenience we need a single "directory" of all the providers existing in our system. ProviderName fills that gap.
  2. Defining a credentials input currently requires defining the provider and credential type(s) both on CredentialsMetaInput and CredentialsField. For better DX, this redundancy should be removed, but without compromising schema generation and data validation.
@Pwuts Pwuts added DX platform/backend AutoGPT Platform - Back end labels Dec 10, 2024 — with Linear
@Pwuts Pwuts self-assigned this Dec 10, 2024
@Pwuts Pwuts mentioned this issue Dec 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2024
@Pwuts
refactor(backend): Simplify CredentialsField usage + use `ProviderN…
33b9eef 
…ame` globally (#8725)

- Resolves #8931
- Follow-up to #8358

### Changes 🏗️
- Avoid double specifying provider and cred types on `credentials`
inputs
- Move `credentials` sub-schema validation from `CredentialsField` to
`CredentialsMetaInput.validate_credentials_field_schema(..)`, which is
called in `BlockSchema.__pydantic_init_subclass__`
- Use `ProviderName` enum globally
@Pwuts Pwuts closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pwuts Pwuts

Labels
DX platform/backend AutoGPT Platform - Back end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pwuts