Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two fields to table 'Relation to foreign signs' #93

Open
ocrasborn opened this issue Oct 2, 2015 · 9 comments
Open

Add two fields to table 'Relation to foreign signs' #93

ocrasborn opened this issue Oct 2, 2015 · 9 comments

Comments

@ocrasborn
Copy link
Collaborator

ocrasborn commented Oct 2, 2015

  1. Foreign translation equivalents (field: other_lang_transl), where we can put in any string
  2. Link (field: other_lang_link), where we'd paste in a URL to anywhere

...and add those to the table in the detail view and to the search panel Relations to foreign signs. To make some space in the table, "Gloss in related language" can be cut to "Gloss" (translation)"

@vanlummelhuizen
Copy link
Collaborator

@ocrasborn is this issue still relevant?

@ocrasborn
Copy link
Collaborator Author

yes, it is @vanlummelhuizen

@ocrasborn ocrasborn removed their assignment Mar 27, 2020
@susanodd susanodd self-assigned this Jul 8, 2022
@susanodd
Copy link
Collaborator

susanodd commented Jul 8, 2022

See (2) in Issue description.
@Woseseltops what about the link url field wrt to the database?

@susanodd
Copy link
Collaborator

Here is a mockup showing the two extra fields (columns) to be added. (To see what this would look like.)

gloss-related-signs-foreign-signs

susanodd pushed a commit that referenced this issue Dec 22, 2022
Relations to foreign signs in Relations View table.
@susanodd
Copy link
Collaborator

The revised Relations View is awaiting review.

susanodd added a commit that referenced this issue Jan 30, 2023
Issue #703, Issue #93: Buttons in Frequency View translatable
@susanodd
Copy link
Collaborator

susanodd commented May 30, 2023

Some time ago, the two new fields were added to the Relations View for a Gloss.
But they are not yet added to the model.

Bullet (1) of the issue is Translation Equivalents. This is perhaps relevant for Senses.
https://signbank.cls.ru.nl/dictionary/gloss_relations/4619

@vanlummelhuizen
Copy link
Collaborator

@susanodd What should we do with this issue?

@susanodd
Copy link
Collaborator

I'm not sure. It's easy to just add the fields. It probably just needs to mention senses.

I didn't implement it except in the template because at the time it would have involved a migration.
We'll assign it to @ocrasborn .

@susanodd susanodd assigned ocrasborn and unassigned susanodd May 31, 2023
@ocrasborn
Copy link
Collaborator Author

ocrasborn commented Jun 1, 2023

Haha, yes, let him decide! ;-) @susanodd , no complex senses needed here for 'foreign language translations' here. Adding a URL would still be helpful. But let's make this lower priority, focusing on the senses first.

@ocrasborn ocrasborn removed their assignment Jun 1, 2023
@susanodd susanodd self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants