Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a page for Dataset Managers under menu Dataset #422

Closed
ocrasborn opened this issue Feb 9, 2018 · 10 comments
Closed

Set up a page for Dataset Managers under menu Dataset #422

ocrasborn opened this issue Feb 9, 2018 · 10 comments

Comments

@ocrasborn
Copy link
Collaborator

ocrasborn commented Feb 9, 2018

  • Menu item/page should only be visible for groups Dataset Manager and Publisher
  • Page should contain a list of datasets for which the user has been assigned as a dataset manager (= Create new object permission "manager" #423 )
  • Page should display and allow for modifying object permissions for the dataset. Perhaps not displaying the list of all users, which will become larger and larger, but by searching for First name and/or Surname?
@susanodd
Copy link
Collaborator

susanodd commented Mar 2, 2018

I started working on this. So far, without manager permissions, just to see what the interface can be.
Here is an example with the lists of view and change users for each dataset.
I made it be username, with a tooltip hover to show first_name and last_name.
I'll work on how to allow updating the permissions next. There might need to be a detail view.

dataset-manager-tooltip-user

@ocrasborn
Copy link
Collaborator Author

Perhaps you already had this in mind, @susanodd , but it would be good to filter this list in such a way that a dataset manager can only see the datasets for which s/he has management permissions (#423). If only for privacy's sake.

@susanodd
Copy link
Collaborator

susanodd commented Mar 6, 2018

Here's what it looks like now. (See below.) I put in parameter checking for various cases (10 different error messages and 6 different success messages). The functionality currently uses the Dataset Manager group and the change_dataset permission (for the logged in user) in order to change the permissions (of other users).

dataset-manager-select-user
dataset-manager-info

@susanodd
Copy link
Collaborator

susanodd commented Mar 6, 2018

I'll work on the revised Dataset Manager permissions (the emails) next. I'll put this version online so it can be experimented with.
Offline, I'm superuser on my local signbank, so I had to login as the test user-dataset in order to view the page properly (with a dataset list restricted to those the user can manage).
I made it so the staff and superuser status isn't shown in the list of users, as can be seen above.

@ocrasborn
Copy link
Collaborator Author

Would it be an idea to also list the current users in two columns to the right of "Users View Dataset" and "Users Change Dataset"? Or would that become too tight? The nice thing would be that managers then immediately see the result of what they do in the updated list.

@susanodd
Copy link
Collaborator

susanodd commented Mar 7, 2018

The list is visible after you click on Manage. It is updated after you add a user.
It folds back up at the moment so you have to click on Manage again to see the updated list.
I will alter the display.

@susanodd
Copy link
Collaborator

susanodd commented Mar 7, 2018

dataset-manager-list-view-users

susanodd pushed a commit that referenced this issue Mar 8, 2018
@susanodd
Copy link
Collaborator

susanodd commented Mar 8, 2018

I modified the page so that after you have added a permission for a user, the Manage area stays open so you can see the changed list.

susanodd pushed a commit that referenced this issue Apr 25, 2018
… datasets. Added a table heading for the Dataset List views.
@vanlummelhuizen
Copy link
Collaborator

@ocrasborn @susanodd is this one done?

@susanodd
Copy link
Collaborator

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants