Revert "fix: communication.callsignVhf not set properly in baseDeltas…

….json" (#1843)

This reverts commit 8fdca1a.

src/config/config.ts

@@ -332,19 +332,8 @@ function getFullDefaults(app: ConfigApp) {
 function setBaseDeltas(app: ConfigApp) {
   const defaultsPath = getBaseDeltasPath(app)
   try {
-    const de = app.config.baseDeltaEditor
-
-    de.load(defaultsPath)
+    app.config.baseDeltaEditor.load(defaultsPath)
     debug(`Found default deltas at ${defaultsPath.toString()}`)
-
-    //fix old, incorrectly done callsignVhf
-    const communication = de.getSelfValue('communication')
-    if (communication) {
-      if (communication.callsignVhf) {
-        de.setSelfValue('communication.callsignVhf', communication.callsignVhf)
-      }
-      de.setSelfValue('communication', undefined)
-    }
   } catch (e) {
     if ((e as any)?.code === 'ENOENT') {
       debug(`No default deltas found at ${defaultsPath.toString()}`)

src/serverroutes.ts

@@ -656,6 +656,7 @@ module.exports = function (
 
   app.get(`${SERVERROUTESPREFIX}/vessel`, (req: Request, res: Response) => {
     const de = app.config.baseDeltaEditor
+    const communication = de.getSelfValue('communication')
     const draft = de.getSelfValue('design.draft')
     const length = de.getSelfValue('design.length')
     const type = de.getSelfValue('design.aisShipType')
@@ -670,7 +671,7 @@ module.exports = function (
       gpsFromBow: de.getSelfValue('sensors.gps.fromBow'),
       gpsFromCenter: de.getSelfValue('sensors.gps.fromCenter'),
       aisShipType: type && type.id,
-      callsignVhf: de.getSelfValue('communication.callsignVhf')
+      callsignVhf: communication && communication.callsignVhf
     }
 
     res.json(json)
@@ -811,9 +812,9 @@ module.exports = function (
         : undefined
     )
     de.setSelfValue(
-      'communication.callsignVhf',
+      'communication',
       !isUndefined(vessel.callsignVhf) && vessel.callsignVhf.length
-        ? vessel.callsignVhf
+        ? { callsignVhf: vessel.callsignVhf }
         : undefined
     )