-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce Customizable Base URLs for API Providers #524
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
075099e
feat(custom-base-url): add support for custom base URL configuration
AAClause 456782d
refactor(account_dialog): improve code structure in EditAccountDialog
AAClause 92ef992
feat(account_dialog): enhance validation and focus control
AAClause 9858bac
Update basilisk/config/account_config.py
AAClause 11ee1b6
style(pre-commit.ci): auto fixes from pre-commit hooks
pre-commit-ci[bot] 1bc6569
Update basilisk/config/account_config.py
AAClause d669042
refactor(config): centralize `CUSTOM_BASE_URL_PATTERN` for unified UR…
AAClause 4f6f3cd
refactor(account_dialog): update type annotations to Python 3.10+ syntax
AAClause 5c2d5ef
feat(account_dialog): show default base URL
AAClause File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Definition of
CUSTOM_BASE_URL_PATTERN
.The regex appears sufficiently flexible for basic HTTP/HTTPS URL validation, including optional ports and simple path segments.
Consider clarifying whether you need to support IPv6 addresses, user info, or other URL components. If not, this pattern is acceptable.