Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install-script): handle no sudo command scenerio #6924

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

prashant-shahi
Copy link
Member

@prashant-shahi prashant-shahi commented Jan 26, 2025

Summary

Install script fixes for the scenario where the sudo command does not exist.

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

NA


Important

Enhance install.sh to handle missing sudo command and adjust docker compose command usage based on plugin availability.

  • Behavior:
    • Modify install.sh to handle cases where sudo is not available by checking with hash sudo and providing user guidance.
    • Adjust docker_compose_cmd initialization to default to docker compose and fallback to docker-compose if the plugin is not found.
  • Logging:
    • Add messages to inform the user when running without sudo or when sudo is not found.
    • Add messages to indicate which docker compose command is being used based on plugin availability.

This description was created by Ellipsis for 860fa4a. It will automatically update as commits are pushed.

Signed-off-by: Prashant Shahi <prashant@signoz.io>
@prashant-shahi prashant-shahi requested a review from a team as a code owner January 26, 2025 20:31
@github-actions github-actions bot added the bug Something isn't working label Jan 26, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 860fa4a in 1 minute and 6 seconds

More details
  • Looked at 51 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. deploy/install.sh:317
  • Draft comment:
    The request_sudo function is defined but not used in the script. Consider using it where sudo access is required to ensure consistent handling of sudo permissions.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.
2. deploy/install.sh:464
  • Draft comment:
    The logic for setting docker_compose_cmd is duplicated. It is initially set to docker compose and then conditionally set again. Consider simplifying this logic to avoid redundancy.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The logic for setting docker_compose_cmd is duplicated. It is set to docker compose initially and then conditionally set again. This can be simplified.
3. deploy/install.sh:317
  • Draft comment:
    Use design tokens or predefined color constants instead of hardcoding color values for terminal output. This applies to lines 6-14.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_fj5u82ncdfcOTi9C


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant