Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move hostname to resource attributes for logs qf #6303

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented Oct 28, 2024

Summary

Related Issues / PR's

fixes - https://signoz-team.slack.com/archives/C02TJ466H8U/p1730132055397139

Screenshots

NA

Affected Areas and Manually Tested Areas

  • logs quick filters

Important

Change hostname filter key to host.name and type to resource in LogsQuickFiltersConfig.

  • Behavior:
    • Change hostname filter key from hostname to host.name in LogsQuickFiltersConfig in utils.tsx.
    • Update filter type from tag to resource for hostname.

This description was created by Ellipsis for 3c1ae9a. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Oct 28, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6928f97 in 9 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/pages/LogsExplorer/utils.tsx:71
  • Draft comment:
    The change from 'tag' to 'resource' for the 'hostname' attribute aligns with the type used for other similar attributes like 'service.name' and 'k8s.cluster.name'. Ensure this change is consistent with the intended use of 'resource' in your application.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The change from 'tag' to 'resource' for the 'hostname' attribute seems consistent with other similar attributes.
2. frontend/src/pages/LogsExplorer/utils.tsx:71
  • Draft comment:
    The change from 'tag' to 'resource' for the 'hostname' attribute is consistent with other similar entries and does not violate any specified rules.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The code does not violate any of the specified rules. It uses enums, imports, and exports correctly. The change from 'tag' to 'resource' is consistent with other similar entries.

Workflow ID: wflow_WkKI4IYJd9VP8h9i


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member

It should be host.name as a resource attribute not hostname.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3c1ae9a in 8 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/pages/LogsExplorer/utils.tsx:69
  • Draft comment:
    The change from hostname to host.name is consistent with the naming convention used for other resource attributes, such as service.name and k8s.cluster.name. This improves consistency and clarity.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The change from 'hostname' to 'host.name' aligns with the resource attribute naming convention used elsewhere in the code.

Workflow ID: wflow_QLKOIwuxK5xi9ZBs


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25
Copy link
Member Author

It should be host.name as a resource attribute not hostname.

ahh good catch! fixed this.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit cc90321 into develop Oct 29, 2024
13 of 15 checks passed
@vikrantgupta25 vikrantgupta25 deleted the move-hostname-to-resource branch October 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants