feat: cache GUIDs without any unit IDs mappings for later removal #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep a cache of the last 100 unused GUIDs that no longer have unit IDs associated with them. Once they are evicted from the cache, remove all other information tracked by the `guid` module for those GUIDs. This prevents the number of GUID-to-name mappings from growing without bound, and frees up some memory for garbage collection.
|
This pullup does require that #971 be pulled up as well to fix a Lua codegen bug that isn't caught by the automated TypeScript test harness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep a cache of the last 100 unused GUIDs that no longer have unit
IDs associated with them. Once they are evicted from the cache,
remove all other information tracked by the
guidmodule for thoseGUIDs. This prevents the number of GUID-to-name mappings from
growing without bound, and frees up some memory for garbage
collection.