fix: game client hanging when equipping different equipment set #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLAYER_EQUIPMENT_CHANGED is a bursty event, so the event handlers for it must handle events quickly. Ignore PLAYER_EQUIPMENT_CHANGED if the slot changed isn't a weapon slot since we only listen for this event to update the weapon damage stats. This fixes an issue with the game client hanging when changing specializations and an new equipment set is auto-equipped.
Event handlers always take the event string as the first argument. This fixes an issue where the unit stats were not updated until the next time the player changed talents or zoned into the world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the game client hanging when changing
specializations and a new equipment set is auto-equipped.