Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runeforge()/equippedruneforge() always return false #805

Closed
denis-kam opened this issue Jan 8, 2021 · 0 comments
Closed

Runeforge()/equippedruneforge() always return false #805

denis-kam opened this issue Jan 8, 2021 · 0 comments
Assignees
@Sidoine
Labels
bug

Comments

@denis-kam
Copy link

Ovale/src/states/runeforge.ts

Line 61 in 10a6054

const runeforgePower = C_LegendaryCrafting.GetRuneforgePowerInfo(

Runeforge()/equippedruneforge() always return false because C_LegendaryCrafting.GetRuneforgePowerInfo always returns state=1 no matter equipped or not.

Please port my lua patch to track equipped legendaries.

legendary.diff.txt
@Sidoine Sidoine self-assigned this Jan 11, 2021
@Sidoine Sidoine added the bug label Jan 11, 2021
Hemario added a commit to Hemario/Ovale that referenced this issue Feb 13, 2021
@Hemario
fix(runeforge): ovale should check for bonus id instead of power id
5c45161 
fixes Sidoine#805
@Sidoine Sidoine closed this as completed in 968078a Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sidoine Sidoine

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sidoine @denis-kam