Skip to content

Commit

Permalink
fix: import latest scripts from SimulationCraft 2021-11-17 (#1063)
Browse files Browse the repository at this point in the history
* docs: document the generated runeforgeBonusId array

* fix: update conduit data and DBC type data from WoW 9.1.5

* fix: add missing identifiers for Echoing Reprimand buffs

The Echoing Reprimand buffs corresponding to having the 2nd, 3rd,
4th, or 5th combo point be animacharged for Kyrian rogues were
missing from the spell database.  Add the identifiers used by SimC
to refer to these buffs.

* fix: support (trivially) time_to_sht SimC modifier

The `time_to_sht` modifier for subtlety rogues is the time in
seconds until the next Shadow Techniques proc. Assume it is always
1 second for now, but leave a TODO comment for properly
implementing this modifier.

* fix: support (trivially) rune_word SimC operand

The `rune_word.<shard_type>.<property>` SimC operand checks for
properties of the Shard of Domination bonus if equipped. Assume it
is always true for now since its only use in the APLs is for
subtlety rogue `rune_word.frost.enabled`, but leave a TODO comment
for properly implementing this later.

* fix: import latest scripts from SimC master from 2021-11-17

Import updated scripts from SimulationCraft master branch from
2021-11-17 for WoW 9.1.5 patch.
  • Loading branch information
johnnylam88 authored Nov 22, 2021
1 parent c791090 commit 4158b4b
Show file tree
Hide file tree
Showing 25 changed files with 1,451 additions and 446 deletions.
393 changes: 198 additions & 195 deletions src/engine/dbc.ts

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions src/scripts/ovale_deathknight_spells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ export function registerDeathKnightSpells(scripts: OvaleScriptsClass) {

// THIS PART OF THIS FILE IS AUTOMATICALLY GENERATED
let code = `Define(abomination_limb 315443)
# Sprout an additional limb, dealing 323798s1*13 Shadow damage over 12 seconds to 323798i nearby enemies. Every t1 sec, an enemy is pulled to your location if they are further than 323710s3 yds from you. The same enemy can only be pulled once every 4 seconds.rnrnGain ?a137008[s3 Bone Shield charges][]?a137006[Rime][]?a137007[Runic Corruption][] instantly, and again every ?a353447[s4-353447s2][s4] sec.
# Sprout an additional limb, dealing 323798s1*13 Shadow damage over 12 seconds to all nearby enemies. Deals reduced damage beyond s5 targets. Every t1 sec, an enemy is pulled to your location if they are further than 323710s3 yds from you. The same enemy can only be pulled once every 4 seconds.rnrnGain ?a137008[s3 Bone Shield charges][]?a137006[Rime][]?a137007[Runic Corruption][] instantly, and again every ?a353447[s4-353447s2][s4] sec.
SpellInfo(abomination_limb cd=120 duration=12 tick=1)
# Recently pulled by Abomination Limb and can't be pulled again.
SpellAddBuff(abomination_limb abomination_limb_unused_0 add=1)
# Pulling enemies to your location and dealing 323798s1 Shadow damage to nearby enemies every t1 sec.
SpellAddBuff(abomination_limb abomination_limb add=1)
Define(abomination_limb_unused_0 323710)
# Sprout an additional limb, dealing 323798s1*13 Shadow damage over 12 seconds to 323798i nearby enemies. Every t1 sec, an enemy is pulled to your location if they are further than 323710s3 yds from you. The same enemy can only be pulled once every 4 seconds.rnrnGain ?a137008[s3 Bone Shield charges][]?a137006[Rime][]?a137007[Runic Corruption][] instantly, and again every ?a353447[s4-353447s2][s4] sec.
# Sprout an additional limb, dealing 323798s1*13 Shadow damage over 12 seconds to all nearby enemies. Deals reduced damage beyond s5 targets. Every t1 sec, an enemy is pulled to your location if they are further than 323710s3 yds from you. The same enemy can only be pulled once every 4 seconds.rnrnGain ?a137008[s3 Bone Shield charges][]?a137006[Rime][]?a137007[Runic Corruption][] instantly, and again every ?a353447[s4-353447s2][s4] sec.
SpellInfo(abomination_limb_unused_0 duration=4 gcd=0 offgcd=1)
Define(ancestral_call 274738)
# Invoke the spirits of your ancestors, granting you a random secondary stat for 15 seconds.
Expand Down Expand Up @@ -84,7 +84,7 @@ Define(bone_shield_buff 195181)
# Armor increased by w1*STR/100.rnHaste increased by w4.
SpellAddBuff(bone_shield_buff bone_shield_buff add=1)
Define(bonestorm 194844)
# A whirl of bone and gore batters up to 196528s2 nearby enemies, dealing 196528s1 Shadow damage every t3 sec, and healing you for 196545s1 of your maximum health every time it deals damage (up to s1*s4). Lasts t3 sec per s3 Runic Power spent.
# A whirl of bone and gore batters all nearby enemies, dealing 196528s1 Shadow damage every t3 sec, and healing you for 196545s1 of your maximum health every time it deals damage (up to s1*s4). Lasts t3 sec per s3 Runic Power spent. Deals reduced damage beyond 196528s2 targets.
SpellInfo(bonestorm runicpower=10 max_runicpower=90 cd=60 duration=1 tick=1)
SpellRequire(bonestorm unusable set=1 enabled=(not hastalent(bonestorm_talent)))
# Dealing 196528s1 Shadow damage to nearby enemies every t3 sec, and healing for 196545s1 of maximum health for each target hit (up to s1*s4).
Expand Down Expand Up @@ -113,7 +113,7 @@ Define(cold_heart_buff 281209)
# Every t1 sec, gain a stack of Cold Heart, causing your next Chains of Ice to deal 281210s1 Frost damage. Stacks up to 281209u times.
SpellInfo(cold_heart_buff max_stacks=20 gcd=0 offgcd=1)
Define(consumption 274156)
# Strikes up to s3 enemies in front of you with a hungering attack that deals sw1 Physical damage and heals you for e1*100 of that damage.
# Strikes all enemies in front of you with a hungering attack that deals sw1 Physical damage and heals you for e1*100 of that damage. Deals reduced damage beyond s3 targets.
SpellInfo(consumption cd=30)
SpellRequire(consumption unusable set=1 enabled=(not hastalent(consumption_talent)))
Define(crimson_scourge_buff 81141)
Expand Down Expand Up @@ -200,7 +200,7 @@ Define(frost_strike 49143)
# Chill your ?owb==0[weapon with icy power and quickly strike the enemy, dealing <2hDamage> Frost damage.][weapons with icy power and quickly strike the enemy with both, dealing a total of <dualWieldDamage> Frost damage.]
SpellInfo(frost_strike runicpower=25)
Define(frostscythe 207230)
# A sweeping attack that strikes up to s5 enemies in front of you for s2 Frost damage. This attack benefits from Killing Machine. Critical strikes with Frostscythe deal s3 times normal damage.
# A sweeping attack that strikes all enemies in front of you for s2 Frost damage. This attack benefits from Killing Machine. Critical strikes with Frostscythe deal s3 times normal damage. Deals reduced damage beyond s5 targets.
SpellInfo(frostscythe runes=1 runicpower=-10)
SpellRequire(frostscythe unusable set=1 enabled=(not hastalent(frostscythe_talent)))
Define(frostwyrms_fury 279302)
Expand Down Expand Up @@ -307,7 +307,7 @@ Define(runic_corruption_buff 51460)
# Rune regeneration rate increased by w1.
SpellAddBuff(runic_corruption_buff runic_corruption_buff add=1)
Define(sacrificial_pact 327574)
# Sacrifice your ghoul to deal 327611s1 Shadow damage to 327611s2 nearby enemies and heal for s1 of your maximum health.
# Sacrifice your ghoul to deal 327611s1 Shadow damage to all nearby enemies and heal for s1 of your maximum health. Deals reduced damage beyond 327611s2 targets.
SpellInfo(sacrificial_pact runicpower=20 cd=120)
Define(scourge_strike 55090)
# An unholy strike that deals s2 Physical damage and 70890sw2 Shadow damage, and causes 1 Festering Wound to burst.
Expand Down Expand Up @@ -398,21 +398,21 @@ Define(blood_tap_talent 22135)
Define(blooddrinker_talent 19166)
# Drains o1 health from the target over 3 seconds.rnrnYou can move, parry, dodge, and use defensive abilities while channeling this ability.
Define(bonestorm_talent 21209)
# A whirl of bone and gore batters up to 196528s2 nearby enemies, dealing 196528s1 Shadow damage every t3 sec, and healing you for 196545s1 of your maximum health every time it deals damage (up to s1*s4). Lasts t3 sec per s3 Runic Power spent.
# A whirl of bone and gore batters all nearby enemies, dealing 196528s1 Shadow damage every t3 sec, and healing you for 196545s1 of your maximum health every time it deals damage (up to s1*s4). Lasts t3 sec per s3 Runic Power spent. Deals reduced damage beyond 196528s2 targets.
Define(breath_of_sindragosa_talent 22537)
# Continuously deal 155166s2*<CAP>/AP Frost damage every t1 sec to enemies in a cone in front of you, until your Runic Power is exhausted. Deals reduced damage to secondary targets.rnrn|cFFFFFFFFGenerates 303753s1 lRune:Runes; at the start and end.|r
Define(bursting_sores_talent 22027)
# Bursting a Festering Wound deals s1 more damage, and deals 207267s1 Shadow damage to 207267s3-1 nearby targets.
# Bursting a Festering Wound deals s1 more damage, and deals 207267s1 Shadow damage to all nearby enemies. Deals reduced damage beyond 207267s3 targets.
Define(clawing_shadows_talent 22026)
# Deals s2 Shadow damage and causes 1 Festering Wound to burst.
Define(cold_heart_talent 22018)
# Every t1 sec, gain a stack of Cold Heart, causing your next Chains of Ice to deal 281210s1 Frost damage. Stacks up to 281209u times.
Define(consumption_talent 19220)
# Strikes up to s3 enemies in front of you with a hungering attack that deals sw1 Physical damage and heals you for e1*100 of that damage.
# Strikes all enemies in front of you with a hungering attack that deals sw1 Physical damage and heals you for e1*100 of that damage. Deals reduced damage beyond s3 targets.
Define(defile_talent 22536)
# Defile the targeted ground, dealing (156000s1*(10 seconds+1)/t3) Shadow damage to all enemies over 10 seconds.rnrnWhile you remain within your Defile, your ?s207311[Clawing Shadows][Scourge Strike] will hit 55090s4-1 enemies near the target?a315442|a331119[ and inflict Death's Due for 12 seconds.rnrnDeath's Due reduces damage enemies deal to you by 324164s1, up to a maximum of 324164s1*-324164u and their power is transferred to you as an equal amount of Strength.][.]rnrnIf any enemies are standing in the Defile, it grows in size and deals increasing damage every sec.
Define(frostscythe_talent 22525)
# A sweeping attack that strikes up to s5 enemies in front of you for s2 Frost damage. This attack benefits from Killing Machine. Critical strikes with Frostscythe deal s3 times normal damage.
# A sweeping attack that strikes all enemies in front of you for s2 Frost damage. This attack benefits from Killing Machine. Critical strikes with Frostscythe deal s3 times normal damage. Deals reduced damage beyond s5 targets.
Define(frozen_pulse_talent 22523)
# While you have fewer than m2 full LRune:Runes;, your auto attacks radiate intense cold, inflicting 195750s1 Frost damage on all nearby enemies.
Define(gathering_storm_talent 22531)
Expand Down
Loading

0 comments on commit 4158b4b

Please sign in to comment.