-
Notifications
You must be signed in to change notification settings - Fork 46
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: import latest scripts from SimulationCraft 2021-11-17 (#1063)
* docs: document the generated runeforgeBonusId array * fix: update conduit data and DBC type data from WoW 9.1.5 * fix: add missing identifiers for Echoing Reprimand buffs The Echoing Reprimand buffs corresponding to having the 2nd, 3rd, 4th, or 5th combo point be animacharged for Kyrian rogues were missing from the spell database. Add the identifiers used by SimC to refer to these buffs. * fix: support (trivially) time_to_sht SimC modifier The `time_to_sht` modifier for subtlety rogues is the time in seconds until the next Shadow Techniques proc. Assume it is always 1 second for now, but leave a TODO comment for properly implementing this modifier. * fix: support (trivially) rune_word SimC operand The `rune_word.<shard_type>.<property>` SimC operand checks for properties of the Shard of Domination bonus if equipped. Assume it is always true for now since its only use in the APLs is for subtlety rogue `rune_word.frost.enabled`, but leave a TODO comment for properly implementing this later. * fix: import latest scripts from SimC master from 2021-11-17 Import updated scripts from SimulationCraft master branch from 2021-11-17 for WoW 9.1.5 patch.
- Loading branch information
1 parent
c791090
commit 4158b4b
Showing
25 changed files
with
1,451 additions
and
446 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.