Skip to content

Commit

Permalink
fix: import latest scripts from SimulationCraft 2021-11-01 (#1052)
Browse files Browse the repository at this point in the history
* fix: support (and ignore) landing_distance SimC modifier

The `landing_distance` modifier for demon hunter Metamorphosis is
used by SimC to indicate the distance that the DH is leaping for
Metamorphosis in order to determine the impact damage on nearby
mobs, but it is irrelevant for Ovale.

* fix: import scripts from SimC master from 2021-11-01

Import updated scripts from SimulationCraft master branch from
2021-11-01 for:
  - Death Knight (frost, unholy)
  - Demon Hunter (havoc)
  - Druid (balance)
  - Hunter (survival)
  • Loading branch information
johnnylam88 authored Nov 2, 2021
1 parent dd4da10 commit 2b83370
Show file tree
Hide file tree
Showing 7 changed files with 487 additions and 388 deletions.
596 changes: 326 additions & 270 deletions src/scripts/ovale_deathknight.ts

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions src/scripts/ovale_deathknight_spells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,11 @@ Define(frostscythe 207230)
Define(frostwyrms_fury 279302)
# Summons a frostwyrm who breathes on all enemies within s1 yd in front of you, dealing 279303s1 Frost damage and slowing movement speed by (25 of Spell Power) for 10 seconds.
SpellInfo(frostwyrms_fury cd=180 duration=10)
Define(gathering_storm_buff 211805)
# Each Rune spent during Remorseless Winter increases its damage by 211805s1, and extends its duration by m1/10.1 sec.
SpellInfo(gathering_storm_buff duration=8 max_stacks=10 gcd=0 offgcd=1)
# Remorseless Winter damage increased by s1.
SpellAddBuff(gathering_storm_buff gathering_storm_buff add=1)
Define(glacial_advance 194913)
# Summon glacial spikes from the ground that advance forward, each dealing 195975s1*<CAP>/AP Frost damage and applying Razorice to enemies near their eruption point.
SpellInfo(glacial_advance runicpower=30 cd=6)
Expand Down Expand Up @@ -422,6 +427,8 @@ Define(hypothermic_presence_talent 22533)
# Embrace the ice in your veins, reducing the Runic Power cost of your abilities by s1 for 8 seconds. Does not trigger the global cooldown.
Define(icecap_talent 22023)
# Your Frost Strike?s207230[, Frostscythe,][] and Obliterate critical strikes reduce the remaining cooldown of Pillar of Frost by <cd> sec.
Define(icy_talons_talent 22017)
# Your Runic Power spending abilities increase your melee attack speed by 194879s1 for 6 seconds, stacking up to 194879u times.
Define(obliteration_talent 22109)
# While Pillar of Frost is active, Frost Strike?s194913[, Glacial Advance,][] and Howling Blast always grant Killing Machine and have a s2 chance to generate a Rune.
Define(rapid_decomposition_talent 19218)
Expand Down
122 changes: 68 additions & 54 deletions src/scripts/ovale_demonhunter.ts

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/scripts/ovale_demonhunter_spells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ Define(unbound_chaos_talent 22494)
# Activating Immolation Aura increases the damage of your next Fel Rush by 347462s1. Lasts 20 seconds.
Define(potion_of_phantom_fire_item 171349)
ItemInfo(potion_of_phantom_fire_item cd=300 shared_cd="item_cd_4" rppm=12 proc=307495)
Define(agony_gaze_runeforge 7681)
Define(blind_faith_runeforge 7699)
Define(burning_wound_runeforge 7219)
Define(chaos_theory_runeforge 7050)
Expand Down
34 changes: 17 additions & 17 deletions src/scripts/ovale_druid.ts

Large diffs are not rendered by default.

113 changes: 66 additions & 47 deletions src/scripts/ovale_hunter.ts

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/simulationcraft/definitions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ export interface Modifiers {
interrupt_if?: ParseNode;
interrupt_immediate?: ParseNode;
interval?: ParseNode;
landing_distance?: ParseNode;
lethal?: ParseNode;
line_cd?: ParseNode;
max_cycle_targets?: ParseNode;
Expand Down Expand Up @@ -472,6 +473,7 @@ export const modifierKeywords: TypeCheck<Modifiers> = {
["interrupt_if"]: true,
["interrupt_immediate"]: true,
["interval"]: true,
["landing_distance"]: true,
["lethal"]: true,
["line_cd"]: true,
["max_cycle_targets"]: true,
Expand Down

0 comments on commit 2b83370

Please sign in to comment.