-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to configure increment on numbered list #152
Conversation
`g:mkdx#settings.enter.increment` allows to configure how new item index is increment or decremented in case reorder/ delete
Hello @yogeshlonkar, cheers for the PR, although I do wonder a bit why this was needed (forgive my potentially naive mindset 😅). If you don't want to explicitly number list items then you already have the ability to use an unordered list already with |
With this you can create list like
This list creates above screenshot Update: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello again Yoge, I understood that the code would end up creating the structure in your first example though I'm not sure how this would allow for the second example since all lists in mkdx are assumed to use one style per list only. e.g. I'm not sure what my code would even do in case of the second example using the mixed numeric / roman numeral style.
That said this seems like a pretty safe feature since it defaults to its original non-configurable value so no harm will really be done here. I added a review comment which will need to be fixed before I merge (it's about adding some missing docs).
Cheers for the PR and apologies for the delays in replies 👍
For reference, in above commit you can see what I changed in addition to your additions to the documentation. This PR has been merged 🎉 Cheers for your patience and the contribution 👍 |
@SidOfc thanks |
g:mkdx#settings.enter.increment
allows to configure how new item indexis increment or decremented in case reorder/ delete
This is useful if you don't want to explicitly number items