Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(walletd): generate seed address no prefix #806

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Nov 4, 2024

  • Updated the seed wallet address generation process to strip the address prefix, which matches the recent API change.

  • Opted to strip the prefix rather than update the SDK/core which had a whole series of cascading incompatibilities.

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 8:52pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 8:52pm
hostd ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 8:52pm
renterd ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 8:52pm
website ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 8:52pm

Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 06a3a83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
walletd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

Copy link
Member Author

alexfreska commented Nov 5, 2024

Merge activity

  • Nov 5, 9:36 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 5, 9:37 AM EST: A user merged this pull request with Graphite.

@alexfreska alexfreska merged commit 0322114 into main Nov 5, 2024
38 checks passed
@alexfreska alexfreska deleted the fix_walletd_generate_seed_address_no_prefix branch November 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants