Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explorer): fix network request calls when navigating to block by height #799

Conversation

telestrial
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:23pm
explorer-zen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:23pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hostd ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 7:23pm
renterd ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 7:23pm
website ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 7:23pm

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 4f27277

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
explorer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

telestrial commented Oct 29, 2024

Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good candidate to add in the tests.

@telestrial
Copy link
Contributor Author

Looks good, good candidate to add in the tests.

That's exactly how I found it. Wrote the test and got the errant result.

Copy link
Contributor Author

telestrial commented Nov 5, 2024

Merge activity

  • Nov 5, 2:17 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 5, 2:18 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 5, 2:19 PM EST: A user merged this pull request with Graphite.

@telestrial telestrial force-pushed the 10-29-fix_explorer_fix_network_request_calls_when_navigating_to_block_by_height branch from 4f27277 to 49b78bb Compare November 5, 2024 19:17
@telestrial telestrial merged commit 6172484 into main Nov 5, 2024
9 of 32 checks passed
@telestrial telestrial deleted the 10-29-fix_explorer_fix_network_request_calls_when_navigating_to_block_by_height branch November 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants