Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus encoding #1525

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Prometheus encoding #1525

wants to merge 11 commits into from

Conversation

chris124567
Copy link
Member

@chris124567 chris124567 commented Sep 12, 2024

Continuation of #1068

Addressed some of the concerns in the reviews:

  • Move PrometheusMetric method to original type where possible
  • Move writeResponse logic to api package
  • Improve handling slices of Prometheus marshallable types
  • Disable type checking in jape

@chris124567 chris124567 marked this pull request as ready for review September 18, 2024 15:23
@ChrisSchinnerl ChrisSchinnerl modified the milestones: v1.2.0, v2.1.0, v2.0.0 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants